* Re: [PATCH 1/1] r8169: fix the typo
[not found] <1482981062-6889-1-git-send-email-yanjun.zhu@oracle.com>
@ 2016-12-30 2:19 ` Yanjun Zhu
0 siblings, 0 replies; only message in thread
From: Yanjun Zhu @ 2016-12-30 2:19 UTC (permalink / raw)
To: nic_swsd, netdev
Hi,
Please comment on this patch.
Zhu Yanjun
On 2016/12/29 11:11, Zhu Yanjun wrote:
> >From the realtek data sheet, the PID0 should be bit 0.
>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@oracle.com>
> ---
> drivers/net/ethernet/realtek/r8169.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 44389c9..8f1623b 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -696,7 +696,7 @@ enum rtl_tx_desc_bit_1 {
> enum rtl_rx_desc_bit {
> /* Rx private */
> PID1 = (1 << 18), /* Protocol ID bit 1/2 */
> - PID0 = (1 << 17), /* Protocol ID bit 2/2 */
> + PID0 = (1 << 17), /* Protocol ID bit 0/2 */
>
> #define RxProtoUDP (PID1)
> #define RxProtoTCP (PID0)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-12-30 2:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1482981062-6889-1-git-send-email-yanjun.zhu@oracle.com>
2016-12-30 2:19 ` [PATCH 1/1] r8169: fix the typo Yanjun Zhu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).