netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Samudrala, Sridhar" <sridhar.samudrala@intel.com>
To: Or Gerlitz <gerlitz.or@gmail.com>
Cc: Alexander Duyck <alexander.h.duyck@intel.com>,
	John Fastabend <john.r.fastabend@intel.com>,
	Anjali Singhai Jain <anjali.singhai@intel.com>,
	jakub.kicinski@netronome.com, intel-wired-lan@lists.osuosl.org,
	Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [net-next PATCH 5/6] i40e: Add TX and RX support in switchdev mode.
Date: Fri, 30 Dec 2016 09:04:38 -0800	[thread overview]
Message-ID: <586693A6.5090105@intel.com> (raw)
In-Reply-To: <CAJ3xEMgDAUSE2gVD3dU4UuXFb7k_W-9QgHpg-0c7b5kxRC2=FQ@mail.gmail.com>

On 12/30/2016 7:31 AM, Or Gerlitz wrote:
> On Fri, Dec 30, 2016 at 8:21 AM, Sridhar Samudrala
> <sridhar.samudrala@intel.com> wrote:
>> In switchdev mode, broadcast filter is not enabled on VFs, The broadcasts and
> nit ", The broadcast" --> ", the broadcasts" or ". The broadcasts"
>
>> unknown frames from VFs are received by the PF and passed to corresponding VF
>> port representator netdev.
>> A host based switching entity like a linux bridge or OVS redirects these frames
>> to the right VFs via VFPR netdevs. Any frames sent via VFPR netdevs are sent as
>> directed transmits to the corresponding VFs. To enable directed transmit, skb
>> metadata dst is used to pass the VF id and the frame is requeued to call the PFs
>> transmit routine.
> So the representator netdevs do or don't have TX/RX rings of their
> own? if the latter, was there any special locking you had to do for
> that?
Atleast in the inital implementation,  we are not creating any TX/RX 
rings for VFPR netdevs.
skb->dev is set to the PF device  and skb is requeued via dev_queue_xmit().


>
> Are you exposing switchdev ops for the representators? didn't see that
> or maybe it's in the 4th patch which didn't make it to the list?
Not at this time. In the future patches when we offload fdb/vlan 
functionality, we could use
switchdev ops.

  reply	other threads:[~2016-12-30 17:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-30  6:20 [net-next PATCH 0/6] i40e: Add VF port representator support or SR-IOV VFs Sridhar Samudrala
2016-12-30  2:53 ` David Miller
2016-12-30 16:55   ` Samudrala, Sridhar
2016-12-30  6:20 ` [net-next PATCH 1/6] i40e: Introduce devlink interface Sridhar Samudrala
2016-12-30  6:20 ` [net-next PATCH 2/6] i40e: Introduce VF Port Representator(VFPR) netdevs Sridhar Samudrala
2016-12-30  2:52   ` David Miller
2016-12-30  6:21 ` [net-next PATCH 3/6] i40e: Sync link state between VFs and VFPRs Sridhar Samudrala
2016-12-30 15:43   ` Or Gerlitz
2016-12-30 17:10     ` Samudrala, Sridhar
2016-12-30  6:21 ` [net-next PATCH 5/6] i40e: Add TX and RX support in switchdev mode Sridhar Samudrala
2016-12-30 15:31   ` Or Gerlitz
2016-12-30 17:04     ` Samudrala, Sridhar [this message]
2017-01-03 23:03       ` Or Gerlitz
2017-01-04 22:46         ` Samudrala, Sridhar
2017-01-05 11:50           ` Or Gerlitz
2017-01-05 22:32             ` Samudrala, Sridhar
2017-01-06  9:24               ` Or Gerlitz
2016-12-30  6:21 ` [net-next PATCH 6/6] i40e: Add support for exposing VF port statistics via VFPR netdev on the host Sridhar Samudrala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=586693A6.5090105@intel.com \
    --to=sridhar.samudrala@intel.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=anjali.singhai@intel.com \
    --cc=gerlitz.or@gmail.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jakub.kicinski@netronome.com \
    --cc=john.r.fastabend@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).