From: Daniel Borkmann <daniel@iogearbox.net>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>, netdev@vger.kernel.org
Cc: alexei.starovoitov@gmail.com
Subject: Re: [PATCH net-next 0/6] Prepare BPF for VLAN_TAG_PRESENT cleanup
Date: Wed, 04 Jan 2017 21:11:57 +0100 [thread overview]
Message-ID: <586D570D.9060800@iogearbox.net> (raw)
In-Reply-To: <cover.1483492355.git.mirq-linux@rere.qmqm.pl>
On 01/04/2017 02:18 AM, Michał Mirosław wrote:
> Those patches prepare BPF ant its JITs for removal of VLAN_TAG_PRESENT.
> The set depends on "Preparation for VLAN_TAG_PRESENT cleanup" patchset.
>
> The series is supposed to be bisect-friendly and that requires temporary
> insertion of #define VLAN_TAG_PRESENT in BPF code to be able to split
> JIT changes per architecture.
>
> Michał Mirosław (6):
> net/skbuff: add macros for VLAN_PRESENT bit
> net/bpf_jit: ARM: split VLAN_PRESENT bit handling from VLAN_TCI
> net/bpf_jit: MIPS: split VLAN_PRESENT bit handling from VLAN_TCI
> net/bpf_jit: PPC: split VLAN_PRESENT bit handling from VLAN_TCI
> net/bpf_jit: SPARC: split VLAN_PRESENT bit handling from VLAN_TCI
> net/bpf: split VLAN_PRESENT bit handling from VLAN_TCI
Please add a proper changelog to all the individual patches, right now
they have none. Also, how was this runtime tested? Did you run BPF selftest
suite with them? Seems like they weren't even compile tested properly
given the kbuild bot barking on sparc ...
> arch/arm/net/bpf_jit_32.c | 16 ++++++++++------
> arch/mips/net/bpf_jit.c | 18 ++++++++++--------
> arch/powerpc/net/bpf_jit_comp.c | 17 +++++++++--------
> arch/sparc/net/bpf_jit_comp.c | 18 ++++++++++--------
> include/linux/skbuff.h | 6 ++++++
> net/core/filter.c | 19 +++++++++----------
> 6 files changed, 54 insertions(+), 40 deletions(-)
>
next prev parent reply other threads:[~2017-01-04 20:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 1:18 [PATCH net-next 0/6] Prepare BPF for VLAN_TAG_PRESENT cleanup Michał Mirosław
2017-01-04 1:18 ` [PATCH net-next 2/6] net/bpf_jit: ARM: split VLAN_PRESENT bit handling from VLAN_TCI Michał Mirosław
2017-01-04 1:18 ` [PATCH net-next 1/6] net/skbuff: add macros for VLAN_PRESENT bit Michał Mirosław
2017-01-04 1:18 ` [PATCH net-next 3/6] net/bpf_jit: MIPS: split VLAN_PRESENT bit handling from VLAN_TCI Michał Mirosław
2017-01-04 1:18 ` [PATCH net-next 4/6] net/bpf_jit: PPC: " Michał Mirosław
2017-01-04 1:18 ` [PATCH net-next 6/6] net/bpf: " Michał Mirosław
2017-01-04 1:18 ` [PATCH net-next 5/6] net/bpf_jit: SPARC: " Michał Mirosław
2017-01-04 12:59 ` kbuild test robot
2017-01-04 20:11 ` Daniel Borkmann [this message]
2017-01-04 21:30 ` [PATCH net-next 0/6] Prepare BPF for VLAN_TAG_PRESENT cleanup Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=586D570D.9060800@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexei.starovoitov@gmail.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).