From: Daniel Borkmann <daniel@iogearbox.net>
To: Martin KaFai Lau <kafai@fb.com>, netdev@vger.kernel.org
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH] bpf: Fix test_lru_sanity5() in test_lru_map.c
Date: Tue, 17 Jan 2017 10:07:32 +0100 [thread overview]
Message-ID: <587DDED4.5060706@iogearbox.net> (raw)
In-Reply-To: <1484633849-2742833-1-git-send-email-kafai@fb.com>
On 01/17/2017 07:17 AM, Martin KaFai Lau wrote:
> test_lru_sanity5() fails when the number of online cpus
> is fewer than the number of possible cpus. It can be
> reproduced with qemu by using cmd args "--smp cpus=2,maxcpus=8".
>
> The problem is the loop in test_lru_sanity5() is testing
> 'i' which is incorrect.
>
> This patch:
> 1. Make sched_next_online() always return -1 if it cannot
> find a next cpu to schedule the process.
> 2. In test_lru_sanity5(), the parent process does
> sched_setaffinity() first (through sched_next_online())
> and the forked process will inherit it according to
> the 'man sched_setaffinity'.
>
> Fixes: 5db58faf989f ("bpf: Add tests for the LRU bpf_htab")
> Reported-by: Daniel Borkmann <daniel@iogearbox.net>
> Signed-off-by: Martin KaFai Lau <kafai@fb.com>
Looks good, thanks for fixing!
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
(Patch is against -net tree.)
next prev parent reply other threads:[~2017-01-17 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 6:17 [PATCH] bpf: Fix test_lru_sanity5() in test_lru_map.c Martin KaFai Lau
2017-01-17 9:07 ` Daniel Borkmann [this message]
2017-01-17 18:16 ` Alexei Starovoitov
2017-01-17 20:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=587DDED4.5060706@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexei.starovoitov@gmail.com \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).