From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Subject: Re: [PATCH] bpf: Fix test_lru_sanity5() in test_lru_map.c Date: Tue, 17 Jan 2017 10:16:34 -0800 Message-ID: <587E5F82.2050400@fb.com> References: <1484633849-2742833-1-git-send-email-kafai@fb.com> <587DDED4.5060706@iogearbox.net> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: Alexei Starovoitov , Kernel Team To: Daniel Borkmann , Martin KaFai Lau , Return-path: Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:59670 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751025AbdAQSRT (ORCPT ); Tue, 17 Jan 2017 13:17:19 -0500 In-Reply-To: <587DDED4.5060706@iogearbox.net> Sender: netdev-owner@vger.kernel.org List-ID: On 1/17/17 1:07 AM, Daniel Borkmann wrote: > On 01/17/2017 07:17 AM, Martin KaFai Lau wrote: >> test_lru_sanity5() fails when the number of online cpus >> is fewer than the number of possible cpus. It can be >> reproduced with qemu by using cmd args "--smp cpus=2,maxcpus=8". >> >> The problem is the loop in test_lru_sanity5() is testing >> 'i' which is incorrect. >> >> This patch: >> 1. Make sched_next_online() always return -1 if it cannot >> find a next cpu to schedule the process. >> 2. In test_lru_sanity5(), the parent process does >> sched_setaffinity() first (through sched_next_online()) >> and the forked process will inherit it according to >> the 'man sched_setaffinity'. >> >> Fixes: 5db58faf989f ("bpf: Add tests for the LRU bpf_htab") >> Reported-by: Daniel Borkmann >> Signed-off-by: Martin KaFai Lau > > Looks good, thanks for fixing! > > Acked-by: Daniel Borkmann > > (Patch is against -net tree.) Acked-by: Alexei Starovoitov