From: Murali Karicheri <m-karicheri2@ti.com>
To: "Rosen, Rami" <rami.rosen@intel.com>,
"open list:TI NETCP ETHERNET DRIVER" <netdev@vger.kernel.org>
Subject: Re: iproute2: using .maxattr = IFLA_VLAN_MAX??
Date: Thu, 26 Jan 2017 11:27:41 -0500 [thread overview]
Message-ID: <588A237D.8030007@ti.com> (raw)
In-Reply-To: <9B0331B6EBBD0E4684FBFAEDA55776F93D496CA4@HASMSX110.ger.corp.intel.com>
On 01/23/2017 03:45 PM, Rosen, Rami wrote:
> Hi, Murali,
>
>> This appears to be a cut-n-paste bug as the source is based on ip/iplink_vlan.c and should be fixed to IFLA_HSR_MAX.
>
> You are right.
> The "HSR section" indeed defines IFLA_HSR_MAX in include/linux/if_link.h of iproute2 as the max attributes number.
>
> And in the top of ip/iplink_hsr.c you will find this comment, which enhances your assumption about the origin of this mistake:
>
> /*
> ...
> Based on iplink_vlan.c by Patrick McHardy <kaber@trash.net
> ...
> */
>
> Regards,
> Rami Rosen
>
Hi, Rami,
Thanks for confirming. I will send out a patch for fixing this when I get a chance to
test hsr for my work in the next few days.
--
Murali Karicheri
Linux Kernel, Keystone
prev parent reply other threads:[~2017-01-26 16:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 17:44 iproute2: using .maxattr = IFLA_VLAN_MAX?? Murali Karicheri
2017-01-23 20:45 ` Rosen, Rami
2017-01-26 16:27 ` Murali Karicheri [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=588A237D.8030007@ti.com \
--to=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=rami.rosen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).