From: Alexei Starovoitov <ast@fb.com>
To: "Mickaël Salaün" <mic@digikod.net>, linux-kernel@vger.kernel.org
Cc: <netdev@vger.kernel.org>, Daniel Borkmann <daniel@iogearbox.net>,
"Shuah Khan" <shuah@kernel.org>,
Arnaldo Carvalho de Melo <acme@infradead.org>
Subject: Re: [PATCH net-next v1 7/7] bpf: Always test unprivileged programs
Date: Mon, 6 Feb 2017 08:09:04 -0800 [thread overview]
Message-ID: <58989FA0.7000906@fb.com> (raw)
In-Reply-To: <20170205231428.23846-7-mic@digikod.net>
On 2/5/17 3:14 PM, Mickaël Salaün wrote:
> - if (unpriv && test->prog_type)
> - continue;
> + if (!test->prog_type) {
> + if (!unpriv)
> + set_admin(false);
> + printf("#%d/u %s ", i, test->descr);
> + do_test_single(test, true, &passes, &errors);
> + if (!unpriv)
> + set_admin(true);
> + }
>
> - printf("#%d %s ", i, test->descr);
> - do_test_single(test, unpriv, &passes, &errors);
> + if (!unpriv) {
> + printf("#%d/p %s ", i, test->descr);
> + do_test_single(test, false, &passes, &errors);
> + }
great idea.
Acked-by: Alexei Starovoitov <ast@kernel.org>
as far as other patches.. we need to figure out how to avoid conflicts
between net-next and Arnaldo's tree where Joe's patches went.
Mickael,
can you see some way of splitting the patch set between trees?
Like above test_verfier.c improvement needs to go into net-next.
The rest can go via perf
next prev parent reply other threads:[~2017-02-06 16:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-05 23:14 [PATCH net-next v1 1/7] bpf: Add missing header to the library Mickaël Salaün
2017-02-05 23:14 ` [PATCH net-next v1 2/7] samples/bpf: Ignore already processed ELF sections Mickaël Salaün
2017-02-05 23:14 ` [PATCH net-next v1 3/7] samples/bpf: Reset global variables Mickaël Salaün
2017-02-05 23:14 ` [PATCH net-next v1 4/7] tools: Sync {,tools/}include/uapi/linux/bpf.h Mickaël Salaün
2017-02-06 19:51 ` Mickaël Salaün
2017-02-05 23:14 ` [PATCH net-next v1 5/7] bpf: Simplify bpf_load_program() error handling in the library Mickaël Salaün
2017-02-05 23:14 ` [PATCH net-next v1 6/7] bpf: Use the bpf_load_program() from " Mickaël Salaün
2017-02-06 15:30 ` Daniel Borkmann
2017-02-06 19:16 ` Mickaël Salaün
2017-02-06 19:18 ` Daniel Borkmann
2017-02-06 21:30 ` Mickaël Salaün
2017-02-06 22:44 ` Daniel Borkmann
2017-02-06 22:46 ` Mickaël Salaün
2017-02-05 23:14 ` [PATCH net-next v1 7/7] bpf: Always test unprivileged programs Mickaël Salaün
2017-02-06 15:43 ` Daniel Borkmann
2017-02-06 16:09 ` Alexei Starovoitov [this message]
2017-02-06 19:24 ` Mickaël Salaün
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58989FA0.7000906@fb.com \
--to=ast@fb.com \
--cc=acme@infradead.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mic@digikod.net \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).