netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Arcari <darcari@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Pavel.Belous@aquantia.com
Subject: Re: [PATCH] net: ethernet: aquantia: set net_device mtu when mtu is changed
Date: Mon, 13 Mar 2017 19:02:01 -0400	[thread overview]
Message-ID: <58C724E9.9090602@redhat.com> (raw)
In-Reply-To: <20170313.125614.724873987813626999.davem@davemloft.net>

On 03/13/2017 03:56 PM, David Miller wrote:
> From: David Arcari <darcari@redhat.com>
> Date: Mon, 13 Mar 2017 11:50:50 -0400
> 
>> On 03/13/2017 02:09 AM, David Miller wrote:
>>> From: David Arcari <darcari@redhat.com>
>>> Date: Wed,  8 Mar 2017 16:33:21 -0500
>>>
>>>> When the aquantia device mtu is changed the net_device structure is not
>>>> updated.  As a result the ip command does not properly reflect the mtu change.
>>>>
>>>> Commit 5513e16421cb incorrectly assumed that __dev_set_mtu() was making the
>>>> assignment ndev->mtu = new_mtu;  This is not true in the case where the driver
>>>> has a ndo_change_mtu routine.
>>>>
>>>> Fixes: 5513e16421cb ("net: ethernet: aquantia: Fixes for aq_ndev_change_mtu")
>>>>
>>>> Cc: Pavel Belous <Pavel.Belous@aquantia.com>
>>>> Signed-off-by: David Arcari <darcari@redhat.com>
>>>
>>> Applied, thanks.
>>>
>>
>> Hi David,
>>
>> I see that my patch:
>>
>> "net: ethernet: aquantia: call set_irq_affinity_hint before free_irq"
>>
>> has been applied to net, but I don't see that this patch has been applied.
> 
> It is marked as "changes requested" in patchwork, because you were asked to
> do the restart label removal in a separate patch.
> 


Sorry, I was not clear.  I was trying to ask if your "Applied, thanks" reply
(above) was meant for this email thread.  I believe it was meant for the
set_irq_affinity_hint patch.

Thanks,

-DA

  reply	other threads:[~2017-03-13 23:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-08 21:33 [PATCH] net: ethernet: aquantia: set net_device mtu when mtu is changed David Arcari
2017-03-09 19:02 ` Pavel Belous
2017-03-09 20:01   ` David Arcari
2017-03-09 20:28     ` David Arcari
2017-03-09 20:57       ` Pavel Belous
2017-03-13  6:09 ` David Miller
2017-03-13 15:50   ` David Arcari
2017-03-13 19:56     ` David Miller
2017-03-13 23:02       ` David Arcari [this message]
2017-03-15 20:49 ` Jarod Wilson
  -- strict thread matches above, loose matches on Subject: below --
2017-03-13 23:07 David Arcari
2017-03-14  1:32 ` Pavel Belous
2017-03-15 21:31 ` Jarod Wilson
2017-03-17  3:21 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58C724E9.9090602@redhat.com \
    --to=darcari@redhat.com \
    --cc=Pavel.Belous@aquantia.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).