netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Zi Shen Lim <zlim.lnx@gmail.com>,
	"David S . Miller" <davem@davemloft.net>
Cc: Alexei Starovoitov <ast@kernel.org>,
	Shuah Khan <shuah@kernel.org>,
	netdev@vger.kernel.org
Subject: Re: [PATCH v2 net] selftests/bpf: fix broken build, take 2
Date: Mon, 20 Mar 2017 16:31:28 +0100	[thread overview]
Message-ID: <58CFF5D0.8040708@iogearbox.net> (raw)
In-Reply-To: <1489989794-6859-1-git-send-email-zlim.lnx@gmail.com>

On 03/20/2017 07:03 AM, Zi Shen Lim wrote:
> Merge of 'linux-kselftest-4.11-rc1':
>
> 1. Partially removed use of 'test_objs' target, breaking force rebuild of
> BPFOBJ, introduced in commit d498f8719a09 ("bpf: Rebuild bpf.o for any
> dependency update").
>
>    Update target so dependency on BPFOBJ is restored.
>
> 2. Introduced commit 2047f1d8ba28 ("selftests: Fix the .c linking rule")
> which fixes order of LDLIBS.
>
>    Commit d02d8986a768 ("bpf: Always test unprivileged programs") added
> libcap dependency into CFLAGS. Use LDLIBS instead to fix linking of
> test_verifier.
>
> 3. Introduced commit d83c3ba0b926 ("selftests: Fix selftests build to
> just build, not run tests").
>
>    Reordering the Makefile allows us to remove the 'all' target.
>
> Tested both:
>      selftests/bpf$ make
> and
>      selftests$ make TARGETS=bpf
> on Ubuntu 16.04.2.
>
> Signed-off-by: Zi Shen Lim <zlim.lnx@gmail.com>

Looks reasonable to me as follow up to 1da8ac7c49fb ("selftests/bpf:
fix broken build"), thanks for fixing Zi!

Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Tested-by: Daniel Borkmann <daniel@iogearbox.net>

  reply	other threads:[~2017-03-20 16:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-20  6:03 [PATCH v2 net] selftests/bpf: fix broken build, take 2 Zi Shen Lim
2017-03-20 15:31 ` Daniel Borkmann [this message]
2017-03-20 15:45   ` Alexei Starovoitov
2017-03-20 16:37     ` Shuah Khan
2017-03-22  1:56       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58CFF5D0.8040708@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=ast@kernel.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=zlim.lnx@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).