From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH v2 net] selftests/bpf: fix broken build, take 2 Date: Mon, 20 Mar 2017 16:31:28 +0100 Message-ID: <58CFF5D0.8040708@iogearbox.net> References: <1489989794-6859-1-git-send-email-zlim.lnx@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Alexei Starovoitov , Shuah Khan , netdev@vger.kernel.org To: Zi Shen Lim , "David S . Miller" Return-path: Received: from www62.your-server.de ([213.133.104.62]:55784 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752784AbdCTQL6 (ORCPT ); Mon, 20 Mar 2017 12:11:58 -0400 In-Reply-To: <1489989794-6859-1-git-send-email-zlim.lnx@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On 03/20/2017 07:03 AM, Zi Shen Lim wrote: > Merge of 'linux-kselftest-4.11-rc1': > > 1. Partially removed use of 'test_objs' target, breaking force rebuild of > BPFOBJ, introduced in commit d498f8719a09 ("bpf: Rebuild bpf.o for any > dependency update"). > > Update target so dependency on BPFOBJ is restored. > > 2. Introduced commit 2047f1d8ba28 ("selftests: Fix the .c linking rule") > which fixes order of LDLIBS. > > Commit d02d8986a768 ("bpf: Always test unprivileged programs") added > libcap dependency into CFLAGS. Use LDLIBS instead to fix linking of > test_verifier. > > 3. Introduced commit d83c3ba0b926 ("selftests: Fix selftests build to > just build, not run tests"). > > Reordering the Makefile allows us to remove the 'all' target. > > Tested both: > selftests/bpf$ make > and > selftests$ make TARGETS=bpf > on Ubuntu 16.04.2. > > Signed-off-by: Zi Shen Lim Looks reasonable to me as follow up to 1da8ac7c49fb ("selftests/bpf: fix broken build"), thanks for fixing Zi! Acked-by: Daniel Borkmann Tested-by: Daniel Borkmann