From: Daniel Borkmann <daniel@iogearbox.net>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Johannes Berg <johannes@sipsolutions.net>
Cc: netdev@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH net-next v4 2/2] bpf: remove struct bpf_map_type_list
Date: Tue, 11 Apr 2017 16:48:59 +0200 [thread overview]
Message-ID: <58ECECDB.3000300@iogearbox.net> (raw)
In-Reply-To: <20170411144316.GB10662@ast-mbp.thefacebook.com>
On 04/11/2017 04:43 PM, Alexei Starovoitov wrote:
> On Tue, Apr 11, 2017 at 03:34:58PM +0200, Johannes Berg wrote:
>> From: Johannes Berg <johannes.berg@intel.com>
>>
>> There's no need to have struct bpf_map_type_list since
>> it just contains a list_head, the type, and the ops
>> pointer. Since the types are densely packed and not
>> actually dynamically registered, it's much easier and
>> smaller to have an array of type->ops pointer. Also
>> initialize this array statically to remove code needed
>> to initialize it.
>>
>> In order to save duplicating the list, move it to the
>> types header file added by the previous patch and
>> include it in the same fashion.
>>
>> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>> ---
>> v4: add ifdef on CONFIG_PERF_EVENTS for stack_map_ops
>
> I'm ok if you keep my ack after minor changes like this.
> Acked-by: Alexei Starovoitov <ast@kernel.org>
Me as well, thanks:
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
next prev parent reply other threads:[~2017-04-11 14:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 13:34 [PATCH net-next v4 1/2] bpf: remove struct bpf_prog_type_list Johannes Berg
2017-04-11 13:34 ` [PATCH net-next v4 2/2] bpf: remove struct bpf_map_type_list Johannes Berg
2017-04-11 14:43 ` Alexei Starovoitov
2017-04-11 14:48 ` Daniel Borkmann [this message]
2017-04-11 18:39 ` David Miller
2017-04-11 14:41 ` [PATCH net-next v4 1/2] bpf: remove struct bpf_prog_type_list Alexei Starovoitov
2017-04-11 18:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58ECECDB.3000300@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexei.starovoitov@gmail.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).