Re: [PATCH net] udp: Fix UDP length on last GSO_PARTIAL segment

[Gal Pressman <gal@nvidia.com>]

On 14/05/2026 17:45, Alice Mikityanska wrote:
> I can put it like this:
> 
> udp: gso: Fix handling checksum in __udp_gso_segment
> 
> The cited commit started using msslen for uh->len, but still uses newlen
> to adjust uh->check. Although the checksum is ignored in most cases due
> to the hardware offload, __udp_gso_segment attempts to maintain the
> correct one. Fix uh->check and adjust it by the right value.
> 
> Additionally, after the fix, newlen becomes assigned and unused before
> the loop. The code can be simplified a bit if mss adjustment is dropped,
> so that newlen becomes equal to msslen before the loop, and msslen can
> be also dropped, saving a few lines of code.
> 
> This brings us back to one variable, drops an unneeded arithmetic for
> mss, and fixes the UDP checksum.
> 
> Fixes: b10b446ce7ad ("udp: gso: Use single MSS length in UDP header for GSO_PARTIAL")
> Signed-off-by: Alice Mikityanska <alice@isovalent.com>
> Reviewed-by: Willem de Bruijn <willemb@google.com>

Thanks Alice!

I will take this and submit both fixes.