From: Gerhard Engleder <gerhard@engleder-embedded.com>
To: Jakub Kicinski <kuba@kernel.org>, ast@kernel.org
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, hawk@kernel.org,
amritha.nambiar@intel.com, aleksander.lobakin@intel.com,
j.vosburgh@gmail.com, andy@greyhouse.net, shayagr@amazon.com,
akiyano@amazon.com, ioana.ciornei@nxp.com,
claudiu.manoil@nxp.com, vladimir.oltean@nxp.com,
wei.fang@nxp.com, shenwei.wang@nxp.com, xiaoning.wang@nxp.com,
linux-imx@nxp.com, dmichail@fungible.com, jeroendb@google.com,
pkaligineedi@google.com, shailend@google.com,
jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
horatiu.vultur@microchip.com, UNGLinuxDriver@microchip.com,
kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, peppe.cavallaro@st.com,
alexandre.torgue@foss.st.com, joabreu@synopsys.com,
mcoquelin.stm32@gmail.com, grygorii.strashko@ti.com,
longli@microsoft.com, sharmaajay@microsoft.com,
daniel@iogearbox.net, john.fastabend@gmail.com,
simon.horman@corigine.com, leon@kernel.org,
linux-hyperv@vger.kernel.org
Subject: Re: [PATCH bpf-next 1/3] eth: add missing xdp.h includes in drivers
Date: Wed, 2 Aug 2023 20:06:28 +0200 [thread overview]
Message-ID: <58b4f563-5bfc-65ed-c213-ae17724e5a33@engleder-embedded.com> (raw)
In-Reply-To: <20230802003246.2153774-2-kuba@kernel.org>
On 02.08.23 02:32, Jakub Kicinski wrote:
> Handful of drivers currently expect to get xdp.h by virtue
> of including netdevice.h. This will soon no longer be the case
> so add explicit includes.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
(...)
> diff --git a/drivers/net/ethernet/engleder/tsnep.h b/drivers/net/ethernet/engleder/tsnep.h
> index 11b29f56aaf9..6e14c918e3fb 100644
> --- a/drivers/net/ethernet/engleder/tsnep.h
> +++ b/drivers/net/ethernet/engleder/tsnep.h
> @@ -14,6 +14,7 @@
> #include <linux/net_tstamp.h>
> #include <linux/ptp_clock_kernel.h>
> #include <linux/miscdevice.h>
> +#include <net/xdp.h>
Reviewed-by: Gerhard Engleder <gerhard@engleder-embedded.com>
next prev parent reply other threads:[~2023-08-02 18:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 0:32 [PATCH bpf-next 0/3] net: struct netdev_rx_queue and xdp.h reshuffling Jakub Kicinski
2023-08-02 0:32 ` [PATCH bpf-next 1/3] eth: add missing xdp.h includes in drivers Jakub Kicinski
2023-08-02 2:26 ` Wei Fang
2023-08-02 16:00 ` Alexander Lobakin
2023-08-02 18:06 ` Gerhard Engleder [this message]
2023-08-02 0:32 ` [PATCH bpf-next 2/3] net: move struct netdev_rx_queue out of netdevice.h Jakub Kicinski
2023-08-02 19:42 ` Nambiar, Amritha
2023-08-02 0:32 ` [PATCH bpf-next 3/3] net: invert the netdevice.h vs xdp.h dependency Jakub Kicinski
2023-08-02 2:31 ` [PATCH bpf-next 0/3] net: struct netdev_rx_queue and xdp.h reshuffling Alexei Starovoitov
2023-08-02 3:11 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58b4f563-5bfc-65ed-c213-ae17724e5a33@engleder-embedded.com \
--to=gerhard@engleder-embedded.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=akiyano@amazon.com \
--cc=aleksander.lobakin@intel.com \
--cc=alexandre.torgue@foss.st.com \
--cc=amritha.nambiar@intel.com \
--cc=andy@greyhouse.net \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=claudiu.manoil@nxp.com \
--cc=daniel@iogearbox.net \
--cc=decui@microsoft.com \
--cc=dmichail@fungible.com \
--cc=grygorii.strashko@ti.com \
--cc=haiyangz@microsoft.com \
--cc=hawk@kernel.org \
--cc=horatiu.vultur@microchip.com \
--cc=ioana.ciornei@nxp.com \
--cc=j.vosburgh@gmail.com \
--cc=jeroendb@google.com \
--cc=jesse.brandeburg@intel.com \
--cc=joabreu@synopsys.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=leon@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=longli@microsoft.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=pkaligineedi@google.com \
--cc=shailend@google.com \
--cc=sharmaajay@microsoft.com \
--cc=shayagr@amazon.com \
--cc=shenwei.wang@nxp.com \
--cc=simon.horman@corigine.com \
--cc=vladimir.oltean@nxp.com \
--cc=wei.fang@nxp.com \
--cc=wei.liu@kernel.org \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).