From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH net v2] selftests/bpf: fix broken build due to types.h Date: Thu, 18 May 2017 00:57:04 +0200 Message-ID: <591CD540.1040305@iogearbox.net> References: <20170517221805.1593973-1-yhs@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: kernel-team@fb.com To: Yonghong Song , ast@fb.com, davem@davemloft.net, netdev@vger.kernel.org Return-path: Received: from www62.your-server.de ([213.133.104.62]:43848 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754126AbdEQW5M (ORCPT ); Wed, 17 May 2017 18:57:12 -0400 In-Reply-To: <20170517221805.1593973-1-yhs@fb.com> Sender: netdev-owner@vger.kernel.org List-ID: On 05/18/2017 12:18 AM, Yonghong Song wrote: > Commit 0a5539f66133 ("bpf: Provide a linux/types.h override > for bpf selftests.") caused a build failure for tools/testing/selftest/bpf > because of some missing types: > $ make -C tools/testing/selftests/bpf/ > ... > In file included from /home/yhs/work/net-next/tools/testing/selftests/bpf/test_pkt_access.c:8: > ../../../include/uapi/linux/bpf.h:170:3: error: unknown type name '__aligned_u64' > __aligned_u64 key; > ... > /usr/include/linux/swab.h:160:8: error: unknown type name '__always_inline' > static __always_inline __u16 __swab16p(const __u16 *p) > ... > The type __aligned_u64 is defined in linux:include/uapi/linux/types.h. > > The fix is to copy missing type definition into > tools/testing/selftests/bpf/include/uapi/linux/types.h. > Adding additional include "string.h" resolves __always_inline issue. > > Fixes: 0a5539f66133 ("bpf: Provide a linux/types.h override for bpf selftests.") > Signed-off-by: Yonghong Song Can you elaborate why string.h specifically? Can't we define the __always_inline ourselves? Thanks, Daniel