From: Daniel Borkmann <daniel@iogearbox.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Jiri Pirko <jiri@resnulli.us>,
netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, dsa@cumulusnetworks.com,
edumazet@google.com, alexander.h.duyck@intel.com,
simon.horman@netronome.com, mlxsw@mellanox.com
Subject: Re: [patch iproute2 v2 repost 1/3] tc_filter: add support for chain index
Date: Sat, 27 May 2017 02:24:02 +0200 [thread overview]
Message-ID: <5928C722.2020800@iogearbox.net> (raw)
In-Reply-To: <20170526171137.0acccbc5@xeon-e3>
On 05/27/2017 02:11 AM, Stephen Hemminger wrote:
> On Fri, 26 May 2017 21:48:05 +0200
> Daniel Borkmann <daniel@iogearbox.net> wrote:
>
>> On 05/23/2017 03:40 PM, Jiri Pirko wrote:
>>> Mon, May 22, 2017 at 10:33:15PM CEST, stephen@networkplumber.org wrote:
>> [...]
>>>> Applied to net-next branch of iproute2
>>>
>>> Looks like you missed the uapi part:
>>>
>>> CC tc_filter.o
>>> tc_filter.c: In function ‘tc_filter_modify’:
>>> tc_filter.c:159:34: error: ‘TCA_CHAIN’ undeclared (first use in this function)
>>> addattr32(&req.n, sizeof(req), TCA_CHAIN, chain_index);
>>> ^~~~~~~~~
>>
>> Looks like still unresolved in the iproute2 -net-next branch ...
>
> On the net-next branch include/linux/rtnetlink.h now has TCA_CHAIN, and everything
> builds fine. You may have local changes or be using different includes
Ok, now it works, thanks for pushing the header rebase out.
next prev parent reply other threads:[~2017-05-27 0:24 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 17:27 [patch net-next v3 00/10] net: sched: introduce multichain support for filters Jiri Pirko
2017-05-16 17:27 ` [patch net-next v3 01/10] net: sched: move tc_classify function to cls_api.c Jiri Pirko
2017-05-16 20:25 ` Cong Wang
2017-05-16 21:00 ` Jiri Pirko
2017-05-16 21:03 ` Cong Wang
2017-05-16 21:05 ` Jiri Pirko
2017-05-16 17:27 ` [patch net-next v3 02/10] net: sched: introduce tcf block infractructure Jiri Pirko
2017-05-16 20:51 ` Cong Wang
2017-05-16 20:57 ` Jiri Pirko
2017-05-16 21:34 ` David Miller
2017-05-16 22:34 ` Cong Wang
2017-05-17 5:42 ` Jiri Pirko
2017-05-16 17:27 ` [patch net-next v3 03/10] net: sched: rename tcf_destroy_chain helper Jiri Pirko
2017-05-16 17:27 ` [patch net-next v3 04/10] net: sched: replace nprio by a bool to make the function more readable Jiri Pirko
2017-05-16 17:27 ` [patch net-next v3 05/10] net: sched: move TC_H_MAJ macro call into tcf_auto_prio Jiri Pirko
2017-05-16 21:01 ` Cong Wang
2017-05-16 21:03 ` Jiri Pirko
2017-05-16 22:38 ` Cong Wang
2017-05-17 5:47 ` Jiri Pirko
2017-05-17 12:47 ` Jamal Hadi Salim
2017-05-17 12:53 ` Jiri Pirko
2017-05-16 17:27 ` [patch net-next v3 06/10] net: sched: introduce helpers to work with filter chains Jiri Pirko
2017-05-16 22:17 ` Cong Wang
2017-05-17 5:50 ` Jiri Pirko
2017-05-16 17:27 ` [patch net-next v3 07/10] net: sched: push chain dump to a separate function Jiri Pirko
2017-05-16 17:28 ` [patch net-next v3 08/10] net: sched: introduce multichain support for filters Jiri Pirko
2017-05-16 17:28 ` [patch net-next v3 09/10] net: sched: push tp down to action init Jiri Pirko
2017-05-16 17:28 ` [patch net-next v3 10/10] net: sched: add termination action to allow goto chain Jiri Pirko
2017-05-16 17:29 ` [patch iproute2 v2 repost 1/3] tc_filter: add support for chain index Jiri Pirko
2017-05-16 18:16 ` Stephen Hemminger
2017-05-16 19:47 ` Jiri Pirko
2017-05-22 20:33 ` Stephen Hemminger
2017-05-23 13:40 ` Jiri Pirko
2017-05-26 19:48 ` Daniel Borkmann
2017-05-27 0:11 ` Stephen Hemminger
2017-05-27 0:24 ` Daniel Borkmann [this message]
2017-05-16 17:29 ` [patch iproute2 v2 repost 2/3] tc: actions: add helpers to parse and print control actions Jiri Pirko
2017-06-14 18:32 ` Jiri Benc
2017-06-14 19:18 ` Jiri Pirko
2017-06-14 19:28 ` Jiri Benc
2017-06-14 20:10 ` Jiri Pirko
2017-05-16 17:29 ` [patch iproute2 v2 repost 3/3] tc/actions: introduce support for goto chain action Jiri Pirko
2017-05-31 12:27 ` Jiri Benc
2017-06-02 8:15 ` Jiri Pirko
2017-06-02 8:22 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5928C722.2020800@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@netronome.com \
--cc=stephen@networkplumber.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).