From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [patch iproute2 v2 repost 1/3] tc_filter: add support for chain index Date: Sat, 27 May 2017 02:24:02 +0200 Message-ID: <5928C722.2020800@iogearbox.net> References: <20170516172802.1317-1-jiri@resnulli.us> <20170516172937.1391-1-jiri@resnulli.us> <20170522133315.3490fe0a@xeon-e3> <20170523134042.GC1829@nanopsycho> <59288675.4040009@iogearbox.net> <20170526171137.0acccbc5@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Cc: Jiri Pirko , netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, dsa@cumulusnetworks.com, edumazet@google.com, alexander.h.duyck@intel.com, simon.horman@netronome.com, mlxsw@mellanox.com To: Stephen Hemminger Return-path: Received: from www62.your-server.de ([213.133.104.62]:57173 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1948882AbdE0AYM (ORCPT ); Fri, 26 May 2017 20:24:12 -0400 In-Reply-To: <20170526171137.0acccbc5@xeon-e3> Sender: netdev-owner@vger.kernel.org List-ID: On 05/27/2017 02:11 AM, Stephen Hemminger wrote: > On Fri, 26 May 2017 21:48:05 +0200 > Daniel Borkmann wrote: > >> On 05/23/2017 03:40 PM, Jiri Pirko wrote: >>> Mon, May 22, 2017 at 10:33:15PM CEST, stephen@networkplumber.org wrote: >> [...] >>>> Applied to net-next branch of iproute2 >>> >>> Looks like you missed the uapi part: >>> >>> CC tc_filter.o >>> tc_filter.c: In function ‘tc_filter_modify’: >>> tc_filter.c:159:34: error: ‘TCA_CHAIN’ undeclared (first use in this function) >>> addattr32(&req.n, sizeof(req), TCA_CHAIN, chain_index); >>> ^~~~~~~~~ >> >> Looks like still unresolved in the iproute2 -net-next branch ... > > On the net-next branch include/linux/rtnetlink.h now has TCA_CHAIN, and everything > builds fine. You may have local changes or be using different includes Ok, now it works, thanks for pushing the header rebase out.