From: Daniel Borkmann <daniel@iogearbox.net>
To: David Daney <david.daney@cavium.com>,
Alexei Starovoitov <ast@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@linux-mips.org, ralf@linux-mips.org
Cc: Markos Chandras <markos.chandras@imgtec.com>,
Matt Redfearn <matt.redfearn@imgtec.com>
Subject: Re: [PATCH v2 4/5] MIPS: Add support for eBPF JIT.
Date: Wed, 14 Jun 2017 02:04:51 +0200 [thread overview]
Message-ID: <59407DA3.8050206@iogearbox.net> (raw)
In-Reply-To: <20170613222847.7122-5-david.daney@cavium.com>
On 06/14/2017 12:28 AM, David Daney wrote:
> Since the eBPF machine has 64-bit registers, we only support this in
> 64-bit kernels. As of the writing of this commit log test-bpf is showing:
>
> test_bpf: Summary: 316 PASSED, 0 FAILED, [308/308 JIT'ed]
>
> All current test cases are successfully compiled.
>
> Many examples in samples/bpf are usable, specifically tracex5 which
> uses tail calls works.
>
> Signed-off-by: David Daney <david.daney@cavium.com>
Awesome work, David! The bits interacting with core BPF look
good to me.
Fyi, when Ralf merges this and it goes later on to Linus, there
will be two minor (silent) merge conflicts with net-next tree
(depending which one gets there first):
1) In bpf_int_jit_compile(), below the jited = 1 assignment, there
needs to come a prog->jited_len = image_size.
2) The internal tail call opcode changed from BPF_JMP | BPF_CALL | BPF_X
into BPF_JMP | BPF_TAIL_CALL.
Cheers,
Daniel
next prev parent reply other threads:[~2017-06-14 0:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 22:28 [PATCH v2 0/5] MIPS: Implement eBPF JIT David Daney
2017-06-13 22:28 ` [PATCH v2 1/5] MIPS: Optimize uasm insn lookup David Daney
2017-06-13 22:28 ` [PATCH v2 2/5] MIPS: Correctly define DBSHFL type instruction opcodes David Daney
2017-06-13 22:28 ` [PATCH v2 3/5] MIPS: Add some instructions to uasm David Daney
2017-06-13 22:28 ` [PATCH v2 4/5] MIPS: Add support for eBPF JIT David Daney
2017-06-14 0:04 ` Daniel Borkmann [this message]
2017-06-13 22:28 ` [PATCH v2 5/5] MIPS: Give __secure_computing() access to syscall arguments David Daney
2017-06-14 9:48 ` [PATCH v2 0/5] MIPS: Implement eBPF JIT Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59407DA3.8050206@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=david.daney@cavium.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=markos.chandras@imgtec.com \
--cc=matt.redfearn@imgtec.com \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).