From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: Re: [PATCH net-next] bpf, i40e: Report bpf_prog id during XDP_QUERY_PROG Date: Wed, 21 Jun 2017 10:54:55 -0700 Message-ID: <594AB2EF.2040809@gmail.com> References: <754b16a0b2d98a1c6a3796aaa6701fae0c4e2612.1498065586.git.daniel@iogearbox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Martin KaFai Lau , Alexander Duyck To: Daniel Borkmann , davem@davemloft.net Return-path: Received: from mail-pf0-f195.google.com ([209.85.192.195]:33427 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751487AbdFURzI (ORCPT ); Wed, 21 Jun 2017 13:55:08 -0400 Received: by mail-pf0-f195.google.com with SMTP id w12so32091578pfk.0 for ; Wed, 21 Jun 2017 10:55:08 -0700 (PDT) In-Reply-To: <754b16a0b2d98a1c6a3796aaa6701fae0c4e2612.1498065586.git.daniel@iogearbox.net> Sender: netdev-owner@vger.kernel.org List-ID: On 06/21/2017 10:27 AM, Daniel Borkmann wrote: > Fill the bpf_prog with the id just like we do in other XDP enabled > drivers. > > Signed-off-by: Daniel Borkmann > Cc: Martin KaFai Lau > Cc: Alexander Duyck > --- > drivers/net/ethernet/intel/i40e/i40e_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c > index 2db93d3..6f5adb5 100644 > --- a/drivers/net/ethernet/intel/i40e/i40e_main.c > +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c > @@ -9589,6 +9589,7 @@ static int i40e_xdp(struct net_device *dev, > return i40e_xdp_setup(vsi, xdp->prog); > case XDP_QUERY_PROG: > xdp->prog_attached = i40e_enabled_xdp_vsi(vsi); > + xdp->prog_id = xdp->prog_attached ? vsi->xdp_prog->aux->id : 0; > return 0; > default: > return -EINVAL; > Looks good to me. Acked-by: John Fastabend