From: Daniel Borkmann <daniel@iogearbox.net>
To: Lawrence Brakmo <brakmo@fb.com>, netdev <netdev@vger.kernel.org>
Cc: Kernel Team <kernel-team@fb.com>, Alexei Starovoitov <ast@fb.com>
Subject: Re: [PATCH net-next] bpf: fix return in load_bpf_file
Date: Wed, 05 Jul 2017 00:14:46 +0200 [thread overview]
Message-ID: <595C1356.3000508@iogearbox.net> (raw)
In-Reply-To: <20170704215129.4047623-1-brakmo@fb.com>
On 07/04/2017 11:51 PM, Lawrence Brakmo wrote:
> The function load_bpf_file ignores the return value of
> load_and_attach(), so even if load_and_attach() returns an error,
> load_bpf_file() will return 0.
>
> Now, load_bpf_file() can call load_and_attach() multiple times and some
> can succeed and some could fail. I think the correct behavor is to
> return error on the first failed load_and_attach().
Your SOB is missing.
next prev parent reply other threads:[~2017-07-04 22:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 21:51 [PATCH net-next] bpf: fix return in load_bpf_file Lawrence Brakmo
2017-07-04 22:14 ` Daniel Borkmann [this message]
2017-07-04 22:55 ` Lawrence Brakmo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=595C1356.3000508@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@fb.com \
--cc=brakmo@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).