From: Menglong Dong <menglong.dong@linux.dev>
To: Menglong Dong <menglong8.dong@gmail.com>
Cc: andrii@kernel.org, ast@kernel.org, daniel@iogearbox.net,
martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org,
yonghong.song@linux.dev, john.fastabend@gmail.com,
kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com,
jolsa@kernel.org, davem@davemloft.net, dsahern@kernel.org,
tglx@linutronix.de, mingo@redhat.com, jiang.biao@linux.dev,
bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
hpa@zytor.com, bpf@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next v12 11/13] selftests/bpf: test bpf_get_func_* for fsession
Date: Sat, 24 Jan 2026 13:09:12 +0800 [thread overview]
Message-ID: <5962490.DvuYhMxLoT@7950hx> (raw)
In-Reply-To: <20260124033119.28682-12-dongml2@chinatelecom.cn>
On 2026/1/24 11:31, Menglong Dong wrote:
> Test following bpf helper for fsession:
> bpf_get_func_arg()
> bpf_get_func_arg_cnt()
> bpf_get_func_ret()
> bpf_get_func_ip()
>
> Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn>
> ---
> .../bpf/prog_tests/get_func_args_test.c | 1 +
> .../bpf/prog_tests/get_func_ip_test.c | 2 ++
> .../selftests/bpf/progs/get_func_args_test.c | 31 ++++++++++++++++++-
> .../selftests/bpf/progs/get_func_ip_test.c | 14 +++++++++
> 4 files changed, 47 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/get_func_args_test.c b/tools/testing/selftests/bpf/prog_tests/get_func_args_test.c
> index fadee95d3ae8..96b27de05524 100644
> --- a/tools/testing/selftests/bpf/prog_tests/get_func_args_test.c
> +++ b/tools/testing/selftests/bpf/prog_tests/get_func_args_test.c
> @@ -41,6 +41,7 @@ void test_get_func_args_test(void)
> ASSERT_EQ(skel->bss->test4_result, 1, "test4_result");
> ASSERT_EQ(skel->bss->test5_result, 1, "test5_result");
> ASSERT_EQ(skel->bss->test6_result, 1, "test6_result");
> + ASSERT_EQ(skel->bss->test7_result, 1, "test7_result");
>
> cleanup:
> get_func_args_test__destroy(skel);
> diff --git a/tools/testing/selftests/bpf/prog_tests/get_func_ip_test.c b/tools/testing/selftests/bpf/prog_tests/get_func_ip_test.c
> index c40242dfa8fb..7772a0f288d3 100644
> --- a/tools/testing/selftests/bpf/prog_tests/get_func_ip_test.c
> +++ b/tools/testing/selftests/bpf/prog_tests/get_func_ip_test.c
> @@ -46,6 +46,8 @@ static void test_function_entry(void)
> ASSERT_EQ(skel->bss->test5_result, 1, "test5_result");
> ASSERT_EQ(skel->bss->test7_result, 1, "test7_result");
> ASSERT_EQ(skel->bss->test8_result, 1, "test8_result");
> + ASSERT_EQ(skel->bss->test9_entry_result, 1, "test9_entry_result");
> + ASSERT_EQ(skel->bss->test9_exit_result, 1, "test9_exit_result");
>
> cleanup:
> get_func_ip_test__destroy(skel);
> diff --git a/tools/testing/selftests/bpf/progs/get_func_args_test.c b/tools/testing/selftests/bpf/progs/get_func_args_test.c
> index 5b7233afef05..8ecc5f339552 100644
> --- a/tools/testing/selftests/bpf/progs/get_func_args_test.c
> +++ b/tools/testing/selftests/bpf/progs/get_func_args_test.c
> @@ -1,5 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0
> -#include <linux/bpf.h>
> +#include <vmlinux.h>
> #include <bpf/bpf_helpers.h>
> #include <bpf/bpf_tracing.h>
> #include <errno.h>
> @@ -165,3 +165,32 @@ int BPF_PROG(tp_test2)
>
> return 0;
> }
> +
> +__u64 test7_result = 0;
> +SEC("fsession/bpf_fentry_test1")
> +int BPF_PROG(test7)
> +{
> + __u64 cnt = bpf_get_func_arg_cnt(ctx);
> + __u64 a = 0, z = 0, ret = 0;
> + __s64 err;
> +
> + test7_result = cnt == 1;
> +
> + /* valid arguments */
> + err = bpf_get_func_arg(ctx, 0, &a);
> + test7_result &= err == 0 && ((int) a == 1);
> +
> + /* not valid argument */
> + err = bpf_get_func_arg(ctx, 1, &z);
> + test7_result &= err == -EINVAL;
> +
> + if (bpf_session_is_return(ctx)) {
> + err = bpf_get_func_ret(ctx, &ret);
> + test7_result &= err == 0 && ret == 2;
> + } else {
> + err = bpf_get_func_ret(ctx, &ret);
> + test7_result &= err == 0 && ret == 0;
> + }
> +
> + return 0;
> +}
CI failed, as this testcase can't run on !CONFIG_X86_64, and
"#ifdef __TARGET_ARCH_x86" should be used here.
Will send a V13 later :)
> diff --git a/tools/testing/selftests/bpf/progs/get_func_ip_test.c b/tools/testing/selftests/bpf/progs/get_func_ip_test.c
> index 2011cacdeb18..bd7598a037cd 100644
> --- a/tools/testing/selftests/bpf/progs/get_func_ip_test.c
> +++ b/tools/testing/selftests/bpf/progs/get_func_ip_test.c
> @@ -103,3 +103,17 @@ int BPF_URETPROBE(test8, int ret)
> test8_result = (const void *) addr == (const void *) uprobe_trigger;
> return 0;
> }
> +
> +__u64 test9_exit_result = 0;
> +__u64 test9_entry_result = 0;
> +SEC("fsession/bpf_fentry_test1")
> +int BPF_PROG(test9, int a)
> +{
> + __u64 addr = bpf_get_func_ip(ctx);
> +
> + if (bpf_session_is_return(ctx))
> + test9_exit_result = (const void *) addr == &bpf_fentry_test1;
> + else
> + test9_entry_result = (const void *) addr == &bpf_fentry_test1;
> + return 0;
> +}
>
next prev parent reply other threads:[~2026-01-24 6:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-24 3:31 [PATCH bpf-next v12 00/13] bpf: fsession support Menglong Dong
2026-01-24 3:31 ` [PATCH bpf-next v12 01/13] bpf: add " Menglong Dong
2026-01-24 3:31 ` [PATCH bpf-next v12 02/13] bpf: use the least significant byte for the nr_args in trampoline Menglong Dong
2026-01-24 3:31 ` [PATCH bpf-next v12 03/13] bpf: change prototype of bpf_session_{cookie,is_return} Menglong Dong
2026-01-24 3:31 ` [PATCH bpf-next v12 04/13] bpf: support fsession for bpf_session_is_return Menglong Dong
2026-01-24 4:03 ` bot+bpf-ci
2026-01-24 4:56 ` Menglong Dong
2026-01-24 3:31 ` [PATCH bpf-next v12 05/13] bpf: support fsession for bpf_session_cookie Menglong Dong
2026-01-24 3:31 ` [PATCH bpf-next v12 06/13] bpf,x86: introduce emit_store_stack_imm64() for trampoline Menglong Dong
2026-01-24 3:31 ` [PATCH bpf-next v12 07/13] bpf,x86: add fsession support for x86_64 Menglong Dong
2026-01-24 3:31 ` [PATCH bpf-next v12 08/13] libbpf: add fsession support Menglong Dong
2026-01-24 3:31 ` [PATCH bpf-next v12 09/13] bpftool: " Menglong Dong
2026-01-24 3:31 ` [PATCH bpf-next v12 10/13] selftests/bpf: add testcases for fsession Menglong Dong
2026-01-24 3:31 ` [PATCH bpf-next v12 11/13] selftests/bpf: test bpf_get_func_* " Menglong Dong
2026-01-24 5:09 ` Menglong Dong [this message]
2026-01-24 3:31 ` [PATCH bpf-next v12 12/13] selftests/bpf: add testcases for fsession cookie Menglong Dong
2026-01-24 3:31 ` [PATCH bpf-next v12 13/13] selftests/bpf: test fsession mixed with fentry and fexit Menglong Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5962490.DvuYhMxLoT@7950hx \
--to=menglong.dong@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=hpa@zytor.com \
--cc=jiang.biao@linux.dev \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=menglong8.dong@gmail.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox