From: Daniel Borkmann <daniel@iogearbox.net>
To: Cong Wang <xiyou.wangcong@gmail.com>, netdev@vger.kernel.org
Cc: dsahern@gmail.com, Lawrence Brakmo <brakmo@fb.com>
Subject: Re: [Patch net] bpf: check NULL for sk_to_full_sk() return value
Date: Mon, 17 Jul 2017 21:06:49 +0200 [thread overview]
Message-ID: <596D0AC9.7070505@iogearbox.net> (raw)
In-Reply-To: <20170717184255.6121-1-xiyou.wangcong@gmail.com>
On 07/17/2017 08:42 PM, Cong Wang wrote:
> When req->rsk_listener is NULL, sk_to_full_sk() returns
> NULL too, so we have to check its return value against
> NULL here.
>
> Fixes: 40304b2a1567 ("bpf: BPF support for sock_ops")
> Reported-by: David Ahern <dsahern@gmail.com>
> Tested-by: David Ahern <dsahern@gmail.com>
> Cc: Lawrence Brakmo <brakmo@fb.com>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
next prev parent reply other threads:[~2017-07-17 19:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 18:42 [Patch net] bpf: check NULL for sk_to_full_sk() return value Cong Wang
2017-07-17 19:06 ` Daniel Borkmann [this message]
2017-07-17 20:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=596D0AC9.7070505@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=brakmo@fb.com \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).