From: John Fastabend <john.fastabend@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>, davem@davemloft.net
Cc: ast@fb.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] bpf: reuse tc bpf prologue for sk skb progs
Date: Thu, 17 Aug 2017 09:05:05 -0700 [thread overview]
Message-ID: <5995BEB1.8020509@gmail.com> (raw)
In-Reply-To: <efce6714acbd646c1e83876504ae7c5fb5e12625.1502983087.git.daniel@iogearbox.net>
On 08/17/2017 08:22 AM, Daniel Borkmann wrote:
> Given both program types are effecitvely doing the same in the
> prologue, just reuse the one that we had for tc and only adapt
> to the corresponding drop verdict value. That way, we don't need
> to have the duplicate from 8a31db561566 ("bpf: add access to sock
> fields and pkt data from sk_skb programs") to maintain.
>
> Reported-by: Alexei Starovoitov <ast@kernel.org>
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
> ---
> net/core/filter.c | 47 ++++++++++-------------------------------------
> 1 file changed, 10 insertions(+), 37 deletions(-)
>
Nice clean-up, Thanks.
Acked-by: John Fastabend <john.fastabend@gmail.com>
next prev parent reply other threads:[~2017-08-17 16:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 15:22 [PATCH net-next 0/2] Two BPF smap related followups Daniel Borkmann
2017-08-17 15:22 ` [PATCH net-next 1/2] bpf: don't enable preemption twice in smap_do_verdict Daniel Borkmann
2017-08-17 16:03 ` John Fastabend
2017-08-17 16:10 ` Alexei Starovoitov
2017-08-17 15:22 ` [PATCH net-next 2/2] bpf: reuse tc bpf prologue for sk skb progs Daniel Borkmann
2017-08-17 16:05 ` John Fastabend [this message]
2017-08-17 16:12 ` Alexei Starovoitov
2017-08-17 17:25 ` [PATCH net-next 0/2] Two BPF smap related followups David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5995BEB1.8020509@gmail.com \
--to=john.fastabend@gmail.com \
--cc=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).