From: Daniel Borkmann <daniel@iogearbox.net>
To: Edward Cree <ecree@solarflare.com>,
davem@davemloft.net,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Alexei Starovoitov <ast@fb.com>
Cc: netdev@vger.kernel.org, iovisor-dev <iovisor-dev@lists.iovisor.org>
Subject: Re: [PATCH v2 net-next 2/5] bpf/verifier: when pruning a branch, ignore its write marks
Date: Wed, 23 Aug 2017 16:56:59 +0200 [thread overview]
Message-ID: <599D97BB.7070604@iogearbox.net> (raw)
In-Reply-To: <ec2ee579-8391-c023-348a-770faa6bc5c7@solarflare.com>
On 08/23/2017 04:10 PM, Edward Cree wrote:
> The fact that writes occurred in reaching the continuation state does
> not screen off its reads from us, because we're not really its parent.
> So detect 'not really the parent' in do_propagate_liveness, and ignore
> write marks in that case.
>
> Fixes: dc503a8ad984 ("bpf/verifier: track liveness for pruning")
> Signed-off-by: Edward Cree <ecree@solarflare.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
next prev parent reply other threads:[~2017-08-23 14:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 14:07 [PATCH v2 net-next 0/5] bpf: verifier fixes Edward Cree via iovisor-dev
2017-08-23 14:09 ` [PATCH v2 net-next 1/5] selftests/bpf: add a test for a bug in liveness-based pruning Edward Cree
[not found] ` <83dbbb0c-3cbc-e033-0ceb-f31db6eb57c2-s/n/eUQHGBpZroRs9YW3xA@public.gmane.org>
2017-08-23 14:42 ` Daniel Borkmann via iovisor-dev
2017-08-23 14:43 ` Alexei Starovoitov via iovisor-dev
[not found] ` <f9208b68-466e-c6cb-4d0c-c567e40bdc15-s/n/eUQHGBpZroRs9YW3xA@public.gmane.org>
2017-08-23 14:10 ` [PATCH v2 net-next 2/5] bpf/verifier: when pruning a branch, ignore its write marks Edward Cree via iovisor-dev
[not found] ` <ec2ee579-8391-c023-348a-770faa6bc5c7-s/n/eUQHGBpZroRs9YW3xA@public.gmane.org>
2017-08-23 14:42 ` Alexei Starovoitov via iovisor-dev
2017-08-23 14:56 ` Daniel Borkmann [this message]
2017-08-23 14:10 ` [PATCH v2 net-next 3/5] selftests/bpf: add a test for a pruning bug in the verifier Edward Cree via iovisor-dev
2017-08-23 14:43 ` Daniel Borkmann
2017-08-23 14:10 ` [PATCH v2 net-next 4/5] bpf/verifier: remove varlen_map_value_access flag Edward Cree via iovisor-dev
[not found] ` <34d97e19-2de8-d336-ba13-77d3b02c5f20-s/n/eUQHGBpZroRs9YW3xA@public.gmane.org>
2017-08-23 14:41 ` Alexei Starovoitov via iovisor-dev
2017-08-23 14:44 ` Daniel Borkmann
2017-08-23 14:11 ` [PATCH v2 net-next 5/5] bpf/verifier: document liveness analysis Edward Cree
[not found] ` <3d4870a2-d7ee-2ac0-aaed-a9faeae89b9e-s/n/eUQHGBpZroRs9YW3xA@public.gmane.org>
2017-08-23 14:41 ` Alexei Starovoitov via iovisor-dev
2017-08-23 14:57 ` Daniel Borkmann via iovisor-dev
2017-08-24 5:38 ` [PATCH v2 net-next 0/5] bpf: verifier fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=599D97BB.7070604@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@fb.com \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=iovisor-dev@lists.iovisor.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).