From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nambiar, Amritha" Subject: Re: [iproute2 PATCH] tc: flower: Classify packets based port ranges Date: Thu, 18 Oct 2018 11:25:40 -0700 Message-ID: <59aaf08b-3da9-2574-2dbd-50a686d6b195@intel.com> References: <153935248286.11074.7540456677759477097.stgit@anamhost.jf.intel.com> <20181018122136.GB4558@nanopsycho.orion> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: stephen@networkplumber.org, netdev@vger.kernel.org, jakub.kicinski@netronome.com, sridhar.samudrala@intel.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com To: Jiri Pirko Return-path: Received: from mga11.intel.com ([192.55.52.93]:11332 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726424AbeJSC1y (ORCPT ); Thu, 18 Oct 2018 22:27:54 -0400 In-Reply-To: <20181018122136.GB4558@nanopsycho.orion> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 10/18/2018 5:21 AM, Jiri Pirko wrote: > Fri, Oct 12, 2018 at 03:54:42PM CEST, amritha.nambiar@intel.com wrote: > > [...] > >> @@ -1516,6 +1625,22 @@ static int flower_print_opt(struct filter_util *qu, FILE *f, >> if (nl_type >= 0) >> flower_print_port("src_port", tb[nl_type]); >> >> + if (flower_port_range_attr_type(ip_proto, FLOWER_ENDPOINT_DST, &range) >> + == 0) { >> + flower_print_port_range("dst_port_min", >> + tb[range.min_port_type]); >> + flower_print_port_range("dst_port_max", >> + tb[range.max_port_type]); > > The input and output of iproute2 utils, tc included should be in sync. > So you need to print "range x-y" here. > Agree, will fix in v2. Thanks! > >> + } >> + >> + if (flower_port_range_attr_type(ip_proto, FLOWER_ENDPOINT_SRC, &range) >> + == 0) { >> + flower_print_port_range("src_port_min", >> + tb[range.min_port_type]); >> + flower_print_port_range("src_port_max", >> + tb[range.max_port_type]); >> + } >> + >> flower_print_tcp_flags("tcp_flags", tb[TCA_FLOWER_KEY_TCP_FLAGS], >> tb[TCA_FLOWER_KEY_TCP_FLAGS_MASK]); >> >>