From: David Ahern <dsahern@gmail.com>
To: "Maciej Żenczykowski" <maze@google.com>,
"Alexei Starovoitov" <alexei.starovoitov@gmail.com>
Cc: "Pujari, Bimmy" <bimmy.pujari@intel.com>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"ast@kernel.org" <ast@kernel.org>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
"kafai@fb.com" <kafai@fb.com>,
"Nikravesh, Ashkan" <ashkan.nikravesh@intel.com>,
"Alvarez, Daniel A" <daniel.a.alvarez@intel.com>
Subject: Re: [PATCH bpf-next v7 2/2] selftests/bpf: Selftest for real time helper
Date: Wed, 7 Oct 2020 09:33:26 -0700 [thread overview]
Message-ID: <59b4dd07-16c5-f831-d27f-8c5d4f50d534@gmail.com> (raw)
In-Reply-To: <CANP3RGfyG9_vj5FkgJz2HV+8voLqP3N+6Qi5hpkqJntF0YSy-A@mail.gmail.com>
On 10/5/20 10:36 AM, Maciej Żenczykowski wrote:
>> Don't bother. This helper is no go.
>
> I disagree on the 'no go' -- I do think we should have this helper.
+1
>
> Lets not make bpf even harder to use then it already is...
>
Logging is done using time of day; that is not a posix mistake but a
real need. Users do not file complaints based on a server's boot time or
some random monotonic time; they report a problem based on time-of-day.
Allowing bpf programs to timeofday makes it easier to troubleshoot and
correlate kernel side events to userspace logs.
prev parent reply other threads:[~2020-10-07 16:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 2:05 [PATCH bpf-next v7 1/2] bpf: Add bpf_ktime_get_real_ns bimmy.pujari
2020-10-01 2:05 ` [PATCH bpf-next v7 2/2] selftests/bpf: Selftest for real time helper bimmy.pujari
2020-10-01 5:35 ` Alexei Starovoitov
2020-10-01 21:52 ` Pujari, Bimmy
2020-10-01 22:50 ` Alexei Starovoitov
2020-10-05 17:36 ` Maciej Żenczykowski
2020-10-07 16:33 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59b4dd07-16c5-f831-d27f-8c5d4f50d534@gmail.com \
--to=dsahern@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ashkan.nikravesh@intel.com \
--cc=ast@kernel.org \
--cc=bimmy.pujari@intel.com \
--cc=bpf@vger.kernel.org \
--cc=daniel.a.alvarez@intel.com \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=maze@google.com \
--cc=mchehab@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).