From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Wang, Dongsheng" <wdsch86@gmail.com>
Subject: Re: [PATCH] net: qcom/emac: fix the error of tpd buff address valid
 bit
Date: Fri, 10 Nov 2017 21:24:36 +0800
Message-ID: <59e1172c-6723-ca75-2ee5-f711f6d883cb@gmail.com>
References: <1510307357-16878-1-git-send-email-wds@virtfox.com>
 <5e5da7b4-0baa-067d-5b01-64195106e18c@codeaurora.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: netdev@vger.kernel.org
To: Timur Tabi <timur@codeaurora.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf0-f195.google.com ([209.85.192.195]:53972 "EHLO
        mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751610AbdKJNYo (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 10 Nov 2017 08:24:44 -0500
Received: by mail-pf0-f195.google.com with SMTP id b6so6438326pff.10
        for <netdev@vger.kernel.org>; Fri, 10 Nov 2017 05:24:44 -0800 (PST)
In-Reply-To: <5e5da7b4-0baa-067d-5b01-64195106e18c@codeaurora.org>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hey, Timur,


On 2017/11/10 20:57, Timur Tabi wrote:
> On 11/10/17 3:49 AM, Wang Dongsheng wrote:
>> TPD has 46-bits as buff address valid bit. So fix the buff address
>> from 45-bits to 46-bits.
>
> NAK.
>
> The TPD has 45 bits.  Why do you say it was 46?
>
On QDF2400, EMAC TPD buff address size is [45:0]. buff address_l [31:0], 
buff address_h [31:18].
The address_h should change from [30:18] to [31:18]. So TPD buff address 
should has 46bits.

Cheers,
-Dongsheng