From mboxrd@z Thu Jan 1 00:00:00 1970 From: tanhuazhong Subject: Re: [Patch net-next] net: hns3: fix return value error while hclge_cmd_csq_clean failed Date: Thu, 2 Aug 2018 08:59:03 +0800 Message-ID: <59f1d5b3-7d1d-e030-0629-8c125fee8f79@huawei.com> References: <1533117208-164535-1-git-send-email-tanhuazhong@huawei.com> <20180801.100332.1084702659051147259.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: , To: David Miller Return-path: Received: from szxga07-in.huawei.com ([45.249.212.35]:50211 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729888AbeHBCrp (ORCPT ); Wed, 1 Aug 2018 22:47:45 -0400 In-Reply-To: <20180801.100332.1084702659051147259.davem@davemloft.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 2018/8/2 1:03, David Miller wrote: > From: Huazhong Tan > Date: Wed, 1 Aug 2018 17:53:28 +0800 > >> From: fredalu >> >> While cleaning the command queue, the value of the HEAD register is not >> in the range of next_to_clean and next_to_use, meaning that this value >> is invalid. This also means that there is a hardware error and the >> hardware will trigger a reset soon. At this time we should return an >> error code instead of 0, and HCLGE_STATE_CMD_DISABLE needs to be set to >> prevent sending command again. >> >> Fixes: 3ff504908f95 ("net: hns3: fix a dead loop in hclge_cmd_csq_clean") >> Signed-off-by: Huazhong Tan wq > ---> ^^^ > > I think I know what text editor you use... :-) > > Applied with 'wq' removed from your signoff... Thanks. > > . > Sorry about this, I have sent V2 to fix it. Thanks.:)