From mboxrd@z Thu Jan 1 00:00:00 1970 From: arvindY Subject: Re: [PATCH 2/3] staging: irda: Handle return value of platform_get_irq Date: Thu, 30 Nov 2017 22:15:19 +0530 Message-ID: <5A20359F.10508@gmail.com> References: <1512056616-21065-1-git-send-email-arvind.yadav.cs@gmail.com> <1512056616-21065-3-git-send-email-arvind.yadav.cs@gmail.com> <20171130164124.GB17869@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Cc: devel@driverdev.osuosl.org, lars@metafoo.de, Michael.Hennerich@analog.com, linux-iio@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, samuel@sortiz.org, pmeerw@pmeerw.net, knaack.h@gmx.de, jic23@kernel.org To: Greg KH Return-path: In-Reply-To: <20171130164124.GB17869@kroah.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: netdev.vger.kernel.org Hi Greg, On Thursday 30 November 2017 10:11 PM, Greg KH wrote: > On Thu, Nov 30, 2017 at 09:13:35PM +0530, Arvind Yadav wrote: >> platform_get_irq() can fail here and we must check its return value. >> >> Signed-off-by: Arvind Yadav >> --- >> drivers/staging/irda/drivers/pxaficp_ir.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) > Did you read drivers/staging/irda/TODO? Sorry, Now I have read it. :( > > thanks, > > greg k-h Thanks, ~arvind