From mboxrd@z Thu Jan 1 00:00:00 1970 From: arvindY Subject: Re: [PATCH] net: hns: use put_device() if device_register fail Date: Mon, 12 Mar 2018 21:57:48 +0530 Message-ID: <5AA6AA84.6040001@gmail.com> References: <20180312.104323.14368638452528082.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, linyunsheng@huawei.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: David Miller Return-path: In-Reply-To: <20180312.104323.14368638452528082.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Monday 12 March 2018 08:13 PM, David Miller wrote: > From: Arvind Yadav > Date: Fri, 9 Mar 2018 16:11:17 +0530 > >> if device_register() returned an error! Always use put_device() >> to give up the reference initialized. >> >> Signed-off-by: Arvind Yadav > I do not see anything giving cls_dev an initial non-zero reference > count before this device_register() call. Yes, you are correct there is nothing to release (hnae_release). > > And I have no idea why you use a "!" when saying 'error' you this > commit log message. > Sorry for that. next time I will take care. ~arvind