From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurentiu Tudor Subject: Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support Date: Thu, 5 Apr 2018 10:30:01 +0000 Message-ID: <5AC5FAA8.80409@nxp.com> References: <20180404010549.GA12443@lunn.ch> <20180404124246.GA20869@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Cc: Arnd Bergmann , Ioana Ciornei , gregkh , Linux Kernel Mailing List , Ruxandra Ioana Ciocoi Radulescu , Razvan Stefanescu , Roy Pledge , Networking To: Andrew Lunn , Stuart Yoder Return-path: In-Reply-To: <20180404124246.GA20869@lunn.ch> Content-Language: en-US Content-ID: <054F1A7236CE4F4C83F69E638384D11A@eurprd04.prod.outlook.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hello, My 2c below. On 04/04/2018 03:42 PM, Andrew Lunn wrote: >> I hear you. It is more complicated this way...having all these individu= al >> objects vs just a single "bundle" of them that represents a NIC. But, t= hat's >> the way the DPAA2 hardware is, and we're implementing kernel support for >> the hardware as it is. > > Hi Stuart > > I see we are not making any progress here. > > So what i suggest is you post the kernel code and configuration tool > concept to netdev for a full review. You want reviews from David > Miller, Jiri Pirko, Jakub Kicinski, David Ahern, etc. > I think that the discussion steered too much towards networking related=20 topics, while this ioctl doesn't have much to do with networking. It's just an ioctl for our mc-bus bus driver that is used to manage the=20 devices on this bus through userspace tools. In addition, I'd drop any mention of our reference user space app=20 (restool) to emphasize that this ioctl is not added just for a=20 particular user space app. I think Stuart also mentioned this. --- Thanks & Best Regards, Laurentiu