From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurentiu Tudor Subject: Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support Date: Thu, 5 Apr 2018 12:16:20 +0000 Message-ID: <5AC61393.7090509@nxp.com> References: <20180404010549.GA12443@lunn.ch> <20180404124246.GA20869@lunn.ch> <5AC5FAA8.80409@nxp.com> <20180405114736.GA12178@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Cc: Stuart Yoder , Arnd Bergmann , Ioana Ciornei , gregkh , Linux Kernel Mailing List , Ruxandra Ioana Ciocoi Radulescu , Razvan Stefanescu , Roy Pledge , Networking To: Andrew Lunn Return-path: In-Reply-To: <20180405114736.GA12178@lunn.ch> Content-Language: en-US Content-ID: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 04/05/2018 02:47 PM, Andrew Lunn wrote: > On Thu, Apr 05, 2018 at 10:30:01AM +0000, Laurentiu Tudor wrote: >> Hello, >> >> My 2c below. >> >> On 04/04/2018 03:42 PM, Andrew Lunn wrote: >>>> I hear you. It is more complicated this way...having all these indivi= dual >>>> objects vs just a single "bundle" of them that represents a NIC. But,= that's >>>> the way the DPAA2 hardware is, and we're implementing kernel support f= or >>>> the hardware as it is. >>> >>> Hi Stuart >>> >>> I see we are not making any progress here. >>> >>> So what i suggest is you post the kernel code and configuration tool >>> concept to netdev for a full review. You want reviews from David >>> Miller, Jiri Pirko, Jakub Kicinski, David Ahern, etc. >>> >> >> I think that the discussion steered too much towards networking related >> topics, while this ioctl doesn't have much to do with networking. > > Hi Laurentiu > > So i can use switchdev without it? I can modprobe the switchdev > driver, all the physical interfaces will appear, and i can use ip addr > add etc. I do not need to use a user space tool at all in order to use > the network functionality? Absolutely! In normal use cases the system designer, depending on the requirements,=20 configures the various devices that it desires through a firmware=20 configuration (think something like a device tree). The devices=20 configured are presented on the mc-bus and probed normally by the=20 kernel. The standard networking linux tools can be used as expected. The ioctl is necessary only for more advanced use cases that are=20 supported by this bus. Think "more dynamic" scenarios that involve=20 linking & unlinking various devices at runtime, maybe some=20 virtualization scenarios. Unfortunately I'm not the architect type of=20 guy so I don't have more specific examples to better illustrate ... --- Best Regards, Laurentiu=