From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arend van Spriel Subject: Re: [PATCH] brcmfmac: stop watchdog before detach and free everything Date: Tue, 29 May 2018 11:25:50 +0200 Message-ID: <5B0D1C9E.4000800@broadcom.com> References: <1527493857-2220-1-git-send-email-michael@amarulasolutions.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Kalle Valo , "David S. Miller" , Pieter-Paul Giesberts , Ian Molton , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Michael Trimarchi Return-path: In-Reply-To: <1527493857-2220-1-git-send-email-michael@amarulasolutions.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 5/28/2018 9:50 AM, Michael Trimarchi wrote: > Watchdog need to be stopped in brcmf_sdio_remove to avoid > i > The system is going down NOW! > [ 1348.110759] Unable to handle kernel NULL pointer dereference at virtual address 000002f8 > Sent SIGTERM to all processes [snip] Please send a V2 with your configuration details to the commit message, ie. using built-in driver, no firmware in place, etc. Reviewed-by: Arend van Spriel > Signed-off-by: Michael Trimarchi > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 7 +++++++ > 1 file changed, 7 insertions(+)