From mboxrd@z Thu Jan  1 00:00:00 1970
From: zhong jiang <zhongjiang@huawei.com>
Subject: Re: [PATCH] net/bridge/br_multicast: remove redundant variable "err"
Date: Mon, 6 Aug 2018 10:15:28 +0800
Message-ID: <5B67AF40.70504@huawei.com>
References: <1533478723-18361-1-git-send-email-zhongjiang@huawei.com> <20180805.173336.2098484669514510834.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Cc: <stephen@networkplumber.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
To: David Miller <davem@davemloft.net>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20180805.173336.2098484669514510834.davem@davemloft.net>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On 2018/8/6 8:33, David Miller wrote:
> From: zhong jiang <zhongjiang@huawei.com>
> Date: Sun, 5 Aug 2018 22:18:43 +0800
>
>> @@ -1797,7 +1795,7 @@ static int br_multicast_ipv4_rcv(struct net_bridge *br,
>>  	struct sk_buff *skb_trimmed = NULL;
>>  	const unsigned char *src;
>>  	struct igmphdr *ih;
>> -	int err;
>> +	int err = 0;
>>  
>>  	err = ip_mc_check_igmp(skb, &skb_trimmed);
> The initialization of err to '0' is unnecessary, it gets assigned on
> the very next line.
>
> .
>
 That's right.  I will drop that change and repost.

Thanks,
zhong jiang