From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhong jiang Subject: Re: [PATCH] net: sched: Use FIELD_SIZEOF directly instead of reimplementing its function Date: Wed, 19 Sep 2018 18:30:23 +0800 Message-ID: <5BA2253F.4090409@huawei.com> References: <1537351001-44480-1-git-send-email-zhongjiang@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: , , , , To: Return-path: In-Reply-To: <1537351001-44480-1-git-send-email-zhongjiang@huawei.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 2018/9/19 17:56, zhong jiang wrote: > FIELD_SIZEOF is defined as a macro to calculate the specified vaule. Therefore, > We prefer to use the macro rather than calculating its vaule. s/vaule/value. will resend. sorry. Thanks zhong jiang > Signed-off-by: zhong jiang > --- > net/sched/cls_flower.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c > index 4b8dd37..9aada2d 100644 > --- a/net/sched/cls_flower.c > +++ b/net/sched/cls_flower.c > @@ -993,7 +993,7 @@ static int fl_init_mask_hashtable(struct fl_flow_mask *mask) > } > > #define FL_KEY_MEMBER_OFFSET(member) offsetof(struct fl_flow_key, member) > -#define FL_KEY_MEMBER_SIZE(member) (sizeof(((struct fl_flow_key *) 0)->member)) > +#define FL_KEY_MEMBER_SIZE(member) FIELD_SIZEOF(struct fl_flow_key, member) > > #define FL_KEY_IS_MASKED(mask, member) \ > memchr_inv(((char *)mask) + FL_KEY_MEMBER_OFFSET(member), \