From: zhong jiang <zhongjiang@huawei.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: <davem@davemloft.net>, <jhs@mojatatu.com>,
<xiyou.wangcong@gmail.com>, <jiri@resnulli.us>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Ursula Braun <ubraun@linux.ibm.com>,
Julian Wiedmann <jwi@linux.ibm.com>
Subject: Re: [PATCH 1/5] net: iucv: Use FIELD_SIZEOF directly instead of reimplementing its function
Date: Wed, 19 Sep 2018 19:32:27 +0800 [thread overview]
Message-ID: <5BA233CB.3070401@huawei.com> (raw)
In-Reply-To: <c7c1c701-2146-b8a8-f988-e504ede0bb61@de.ibm.com>
On 2018/9/19 19:21, Christian Borntraeger wrote:
> Can you please copy Ursula and Julian for iucv related patches?
Thanks, Maybe I forget cc more maintainer. So I will resend in v2.
Sincerely,
zhong jiang
> On 09/19/2018 12:26 PM, zhong jiang wrote:
>> FIELD_SIZEOF is defined as a macro to calculate the specified value. Therefore,
>> We prefer to use the macro rather than calculating its value.
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> ---
>> net/iucv/af_iucv.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c
>> index e2f16a0..5b68ee9 100644
>> --- a/net/iucv/af_iucv.c
>> +++ b/net/iucv/af_iucv.c
>> @@ -48,7 +48,7 @@
>> static const u8 iprm_shutdown[8] =
>> {0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01};
>>
>> -#define TRGCLS_SIZE (sizeof(((struct iucv_message *)0)->class))
>> +#define TRGCLS_SIZE FIELD_SIZEOF(struct iucv_message, class)
>>
>> #define __iucv_sock_wait(sk, condition, timeo, ret) \
>> do { \
>>
>
>
next prev parent reply other threads:[~2018-09-19 11:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 10:26 [PATCH 0/5] Use FIELD_SIZEOF directly instead of reimplementing its function zhong jiang
2018-09-19 10:26 ` [PATCH 1/5] net: iucv: " zhong jiang
2018-09-19 11:21 ` Christian Borntraeger
2018-09-19 11:32 ` zhong jiang [this message]
2018-09-19 10:26 ` [PATCH 2/5] net: sched: " zhong jiang
2018-09-19 10:26 ` [PATCH 3/5] net: core: " zhong jiang
2018-09-19 10:26 ` [PATCH 4/5] net: qede: " zhong jiang
2018-09-19 10:26 ` [PATCH 5/5] net: ti: " zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BA233CB.3070401@huawei.com \
--to=zhongjiang@huawei.com \
--cc=borntraeger@de.ibm.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=jwi@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ubraun@linux.ibm.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).