From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhong jiang Subject: Re: [PATCH] brcm80211: remove redundant condition check before debugfs_remove_recursive Date: Thu, 20 Sep 2018 20:37:11 +0800 Message-ID: <5BA39477.7050908@huawei.com> References: <1536761412-24932-1-git-send-email-zhongjiang@huawei.com> <20180920120709.5FE6960BF7@smtp.codeaurora.org> <5BA391D4.20205@huawei.com> <877ejg1hcd.fsf@kamboji.qca.qualcomm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: , , , , , , , To: Kalle Valo Return-path: In-Reply-To: <877ejg1hcd.fsf@kamboji.qca.qualcomm.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 2018/9/20 20:30, Kalle Valo wrote: > zhong jiang writes: > >> On 2018/9/20 20:07, Kalle Valo wrote: >>> zhong jiang wrote: >>> >>>> debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just >>>> remove the condition check before debugfs_remove_recursive. >>>> >>>> Signed-off-by: zhong jiang >>> It seems you already submitted an identical patch four days earlier: >>> >>> https://patchwork.kernel.org/patch/10593061/ >>> >>> Why the duplicate? Please ALWAYS add a changelog and increase the version number: >> I am sorry for that. Maybe I send the patch earlier, but I remeber I >> should forget to cc to >> netdev@vger.kernel.org and LMLK. So I repost it. Plese ingore the current patch. > Even then please increase the version number and mention in the change > log why you sent a new version. Otherwise you will make maintainers > confused and wasting time with asking what has changed. > Get it and will keep it in mind . Thanks Sincerely, zhong jiang