From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhong jiang Subject: Re: [PATCH] libertas: remove set but not used variable 'int_type' Date: Tue, 23 Oct 2018 22:28:10 +0800 Message-ID: <5BCF2FFA.3060109@huawei.com> References: <1540265568-58721-1-git-send-email-zhongjiang@huawei.com> <25ed3d0b71eb34e121f2d7a8d936665d7720270f.camel@v3.sk> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: , , , , , To: Lubomir Rintel Return-path: In-Reply-To: <25ed3d0b71eb34e121f2d7a8d936665d7720270f.camel@v3.sk> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 2018/10/23 22:23, Lubomir Rintel wrote: > On Tue, 2018-10-23 at 11:32 +0800, zhong jiang wrote: >> int_type is not used after setting its value. It is safe to remove >> the unused variable. > Hi. I believe your colleague has sent an equivalent patch a few days > ago in <1539569795-176889-1-git-send-email-yuehaibing@huawei.com>: > > https://lore.kernel.org/linux-wireless/1539569795-176889-1-git-send-email-yuehaibing@huawei.com/ I miss that. Thanks, please ignore the patch. Sincerely, zhong jiang > Cheers, > Lubo > >> Signed-off-by: zhong jiang >> --- >> drivers/net/wireless/marvell/libertas/if_spi.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/net/wireless/marvell/libertas/if_spi.c >> b/drivers/net/wireless/marvell/libertas/if_spi.c >> index 504d6e0..7c3224b 100644 >> --- a/drivers/net/wireless/marvell/libertas/if_spi.c >> +++ b/drivers/net/wireless/marvell/libertas/if_spi.c >> @@ -796,15 +796,13 @@ static void if_spi_h2c(struct if_spi_card >> *card, >> { >> struct lbs_private *priv = card->priv; >> int err = 0; >> - u16 int_type, port_reg; >> + u16 port_reg; >> >> switch (type) { >> case MVMS_DAT: >> - int_type = IF_SPI_CIC_TX_DOWNLOAD_OVER; >> port_reg = IF_SPI_DATA_RDWRPORT_REG; >> break; >> case MVMS_CMD: >> - int_type = IF_SPI_CIC_CMD_DOWNLOAD_OVER; >> port_reg = IF_SPI_CMD_RDWRPORT_REG; >> break; >> default: > > . >