From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhong jiang Subject: Re: [PATCH v2] rtlwifi: remove set but not used variable 'radiob_array_table' and 'radiob_arraylen' Date: Wed, 24 Oct 2018 10:04:00 +0800 Message-ID: <5BCFD310.90305@huawei.com> References: <1540283282-9772-1-git-send-email-zhongjiang@huawei.com> <19b16ca89b5cde607338513638d4ef8e3a3d2802.camel@perches.com> <1540342331.2495.1.camel@realtek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: "kvalo@codeaurora.org" , "linux-wireless@vger.kernel.org" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" To: Pkshih , "joe@perches.com" Return-path: In-Reply-To: <1540342331.2495.1.camel@realtek.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 2018/10/24 8:52, Pkshih wrote: > On Tue, 2018-10-23 at 12:33 -0700, Joe Perches wrote: >> On Tue, 2018-10-23 at 16:28 +0800, zhong jiang wrote: >>> radiob_array_table' and 'radiob_arraylen' are not used after setting its >> value. >>> It is safe to remove the unused variable. Meanwhile, radio B radio should be >>> removed as well. because it will no longer be referenced. >> The patch subject is a bit off and too generic here. >> >> This is specific to rtl8723ae and not rtlwifi so it is >> probably better for the subject to be something like: >> >> [PATCH] rtl8723ae: Remove set but not used variables and #defines > I'd like 'rtlwifi: rtl8723ae: ' as subject prefix. Thanks for your suggestion. Will change the subject and resend. [PATCH] rtlwifi: rtl8723ae: Remove set but not used variables and #defines Thanks, zhong jiang >>> Signed-off-by: zhong jiang >>> --- >>> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 5 +---- >>> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.c | 4 ---- >>> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.h | 2 -- >> >> ------Please consider the environment before printing this e-mail.