netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Rama <john.rama01@gmail.com>
To: netdev@vger.kernel.org
Subject: DSA: external phy address and port number of switch conflicts
Date: Thu, 13 Dec 2018 19:12:05 -0500	[thread overview]
Message-ID: <5C12F555.2070305@gmail.com> (raw)

Dear DSA experts

My name is John.

I'm working for our custom board which has the Marvel 88e5050 ethernet switch
as shown below, and trying to make the system works using DSA subsystem.

I found one problem and have a question.

- System
    - i.MX6 and Marvel 88e5050 Switch(PHY addr is 0x10)
    - port1-5 has integrated PHY
     - port7 is connected to Marvel 88e1510 PHY(PHY addr is 0x1)

                           0x10
    +------------+         +-----------------+
    |            |         | Marvel 88e5050  |
    |            | RGMII   |           port1 |
    |   IMX6     +---------+ port6           |
    |            |         |           port2 |
    |            | MDIO    |                 |
    |            +-+-------+           port3 |
    |            | |       |                 |
    +------------+ |       |           port4 |
                   |       |                 |
                 +-+-+     |           port5 |
                 |   |SGMII|                 |
                 |PHY|-----| port7           |
                 |   |     |                 |
                 +---+     +-----------------+
              Marvel 88e1510
                   0x1                        

- Device Tree setting
    In this configuration, our dts is as followings.

    dsa@0 {
      compatible = "marvell,dsa";
        #address-cells = <2>;
        #size-cells = <0>;

        dsa,ethernet = <&fec>;
        dsa,mii-bus = <&mdio>;

        switch@0 {
            #address-cells = <1>;
            #size-cells = <0>;
            reg = <0x10 0>;    /* MDIO address 16, switch 0 in tree */

            port@1 {
                reg = <1>;
                label = "port1";
            };

            port@2 {
                reg = <2>;
                label = "port2";
            };

            port@3 {
                reg = <3>;
                label = "port3";
            };

            port@4 {
                reg = <4>;
                label = "port4";
            };

            port@5 {
                reg = <5>;
                label = "port5";
            };

            port@6 {
                reg = <6>;
                label = "cpu";
            };

            port@7 {
                reg = <7>;
                label = "port7";
                phy-handle = <&ethphy1>;
                phy-mode = "sgmii";
            };                                       
        };
     };

    mdio: mdio {
        #address-cells = <1>;
        #size-cells = <0>;

        ethphy1: 88e1510{
            reg = <1>;
            phy-mode = "sgmii";
        };

    };
                                
- Problem
    dsa_slave_phy_connect() for port 7 results in attaching Generic PHY,
    as shown in the following log, which is unexpected result.
    dsa dsa@0 port7 (uninitialized): attached PHY at address 1 [Generic PHY]

    This is because port7 PHY addr (reg=<1>) and the port1 port number (reg=<1)> is conflicting.
    If I comment out the port1 setting from DTS, I can get following log,
    everything working fine and

    dsa dsa@0 port7 (uninitialized): attached PHY at address 1 [Marvel 88E1510]

    I'm using a little bit old kernel,4.1.15.
    So I checked the latest code of linux-next, but it seems there is similar problem.

- Question
    Is this system configuration is not supported by DSA ?
    Or am I misunderstand something ?
    Any insights are really appreciated.

John

             reply	other threads:[~2018-12-14  0:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-14  0:12 John Rama [this message]
2018-12-14  5:08 ` DSA: external phy address and port number of switch conflicts Florian Fainelli
2018-12-17 22:55   ` John Rama
2018-12-17 23:03     ` Florian Fainelli
2018-12-18 18:55       ` John Rama
2018-12-14  8:38 ` Andrew Lunn
2018-12-14 16:24 ` Vivien Didelot
2018-12-14 16:31   ` John Rama
  -- strict thread matches above, loose matches on Subject: below --
2018-12-13 23:51 John Rama

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5C12F555.2070305@gmail.com \
    --to=john.rama01@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).