From: Joe Buehler <aspam@cox.net>
To: linville@tuxdriver.com, netdev@vger.kernel.org
Subject: ethtool SFF-8472 issue
Date: Thu, 17 Oct 2019 08:16:38 -0400 [thread overview]
Message-ID: <5DA85BA6.5020305@cox.net> (raw)
In sfpdiag.c the sff8472_calibration routine does not look correct for
optical RX power.
The code is currently calculating this:
power = a + b*x + c*x + d*x // x is the raw A/D reading
First problem is that there is another term (SFF_A2_CAL_RXPWR4 in
sfpdiag.c) in SFF-8472 that has been dropped.
The more serious issue is that this computation is not correct. The
SFF-8472 document could be a little clearer -- which is probably what
caused this -- but I think what it intends is a least-squares polynomial
fit to convert from A/D reading to RX power.
So the formula should be:
power = a + b *x + c*x*x + d*x*x*x + e*x*x*x*x
Joe Buehler
reply other threads:[~2019-10-17 12:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5DA85BA6.5020305@cox.net \
--to=aspam@cox.net \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).