* ethtool SFF-8472 issue
@ 2019-10-17 12:16 Joe Buehler
0 siblings, 0 replies; only message in thread
From: Joe Buehler @ 2019-10-17 12:16 UTC (permalink / raw)
To: linville, netdev
In sfpdiag.c the sff8472_calibration routine does not look correct for
optical RX power.
The code is currently calculating this:
power = a + b*x + c*x + d*x // x is the raw A/D reading
First problem is that there is another term (SFF_A2_CAL_RXPWR4 in
sfpdiag.c) in SFF-8472 that has been dropped.
The more serious issue is that this computation is not correct. The
SFF-8472 document could be a little clearer -- which is probably what
caused this -- but I think what it intends is a least-squares polynomial
fit to convert from A/D reading to RX power.
So the formula should be:
power = a + b *x + c*x*x + d*x*x*x + e*x*x*x*x
Joe Buehler
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-10-17 12:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-17 12:16 ethtool SFF-8472 issue Joe Buehler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).