From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7745399018 for ; Sat, 3 Oct 2026 09:54:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791021244; cv=none; b=SCbT0tq9e5PPvN3rBCwb/ZTzxcleo7AG51KkCvTj8Sviz3nThIIARftU6JUB8Nrydk/xUGJjf6dueTLtqvuN5caNQ6/IlR/4pjoGUf8DjsvCCoGFoH4Mz3zqmDNv/lpjeB8nv5lxIbA3k1horBfbr85ho61WygEFDHrLtcd/A0s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791021244; c=relaxed/simple; bh=PuFx0zWXcplwcO/kwwbec+csZfwCfv3PjuRMiBzgrK4=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=XZJ8/YTJ0zgZndL083EDVXNgh5EtiiAltQWWOykX+r1oxwsR7LdhFTfEpnyFfV9k7xHGheVcn50lvRV1Oj3nIOjA2rMgEyOEay6pJn6nxOB5cCat7cfuzA8783ZCWxUmBtNXD/7znuBcxEi0znDBgPAXXhrGPjeJWvfhMBi52fg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=aywX4vr+; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=HtdP3DZb; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aywX4vr+"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="HtdP3DZb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1791021241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pj3fnkRnguG1XzZ2CAsEmH/UIzLjDfjSPrnu5Kpy4iA=; b=aywX4vr+jaPHR9wHwKFtCLHdgwxLpsZrxWyQxnbQRHpkoiFnVLBMmNWMxLmPezj7Q4CH7Z OvNBHUpaaAKmhjP2iV9PYgEoWK9KtpxsnAHpT7sSKof4aP2Q9G0bbp9SMO/puxbzOEhjBO Fo8YP+Pa0zF/4Y4o2cn/Y92OJeM2GH0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-117-ABTmimegO_md_gWhVgRQiQ-1; Sat, 03 Oct 2026 05:54:00 -0400 X-MC-Unique: ABTmimegO_md_gWhVgRQiQ-1 X-Mimecast-MFC-AGG-ID: ABTmimegO_md_gWhVgRQiQ_1791021239 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-49e6862e924so4689965e9.0 for ; Sat, 03 Oct 2026 02:54:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1791021239; x=1791626039; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:message-id :references:in-reply-to:user-agent:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=pj3fnkRnguG1XzZ2CAsEmH/UIzLjDfjSPrnu5Kpy4iA=; b=HtdP3DZbWeCreZmZN7fUAmzif1TTLCD2K0/R7NvgKggJcSCHrJjMylmT6ue7xwE40s TbnGviD9DHMNXAibM8qXYdnQxdrAY8uOBon9OCwrwCaspyiWmjFZGfIvLMV5LXk24/TD LlnnAz69e1QxX9IbrWZQmVsS6glGm5tJT2gEzXo+e/LwjCmgyWMniTkEkfY3VAioqeei 8DAcnArkz9HlxbOqOrgNGpI1FDkIe66wHiOgrvU4mrqrRlMKiKrjaLH4UGcJ7lnVGQo5 YIlqEh0LL/gIzFcuCxeVU9o3KC5Sdr296uouQEm3Y6GdOKNBELMfqTm+XHGskK9Eo6A4 hBoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791021239; x=1791626039; h=content-transfer-encoding:content-type:mime-version:message-id :references:in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pj3fnkRnguG1XzZ2CAsEmH/UIzLjDfjSPrnu5Kpy4iA=; b=Vc8j0QotgcH6wfgdRyB+ctBoxhry3RSinoRsdPf+FhxP2toaaNMX0+N2FqaNCeR5Rw SDP0l6JGPfS5cf1/z1kDv8YQdiBiVgUbXNZlmcXW1mM8mbWOk1L6ESab6LVziI1iGpjB xgivsRcdxlIiILnjtHjktOu2tB8OeC9Iunp31bGQ5lo42vSULV+VkwrJFuQRRofZ4pqh pHmXOIlttP9iQCPrJExKHPQPMXjYUfn8bW3LYg813BIhSLVtKDlz4bBeggkImtibxOmR jEcOVkdjiysXmW1ef4JMbU+HDEVsvKGsJYAsXaf3zINQwSswHEzG8F32lj6heLFAqE1L dorg== X-Forwarded-Encrypted: i=1; AKwUvBzCXviRAIYt7Sxs3EYhYrBo8epoDX696hs962yenWkzNZB/uorByNdHlx71YA2qWP13ePVD9sg=@vger.kernel.org X-Gm-Message-State: AFuF++lM7ws0t/5L3LlBGNlVYXTsnGsjzOLlAD+WBlWj+8EMFifehtQ5 FIp3AwJ6Rb+lhs1HFrilAPtCTwHLdVtGv24Dn09lD4PbgHxHPs4hHDb1OhgvrgS6SWUibTqLJ2r AiA+P101NeM5bkufuk7C+PNARMZK5EAEsnjP5K3uezV/r44X8pWpfsxy33g== X-Gm-Gg: AYBFou1eYIEZRkF/zM0JdBtfijt7M1NjBugs4mud74qfxWwLUPEXbhk+57lBB+BmTlJ MhXT7nUIRFLn7HcSVKl+7Iao3AF8dcqCsAgEOaQqOPouuwzxd4yn6ziTZJzb+s7yO8HyevbDGdi Z/Pf1XEphzZqCQc9kxAUM9b+qCJTLDdRfEdP6Hyb+LopgyEiQIq2k8yP2UcF7dLLyucbko1/jqP eCr8AlRSYzNP7bGkmhRmmTqdUpfJ+HCEomGQjPo6ohM5oTEZiy0bsg6LD0gMvGq2yA19n9DpqC8 W0A6YoKCjoccXouc4lGIKs6wc02c4NcdvCeG6XEQovbgfn80Xjq5MyG9K3MLdBStcjZsPvG3UTV Mezur1OJhJ00Lv3m1muLbYQTdgVoLczz51G8C9EQ= X-Received: by 2002:a05:600c:3c98:b0:4a0:37d:9e21 with SMTP id 5b1f17b1804b1-4a168101d2dmr29368745e9.29.1791021239020; Sat, 03 Oct 2026 02:53:59 -0700 (PDT) X-Received: by 2002:a05:600c:3c98:b0:4a0:37d:9e21 with SMTP id 5b1f17b1804b1-4a168101d2dmr29368635e9.29.1791021238635; Sat, 03 Oct 2026 02:53:58 -0700 (PDT) Received: from ehlo.thunderbird.net ([2a00:e580:bf11:1:2666:d874:79e6:3214]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48b38104d64sm10844602f8f.29.2026.10.03.02.53.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 03 Oct 2026 02:53:57 -0700 (PDT) Date: Sat, 03 Oct 2026 11:53:56 +0200 From: Ivan Vecera To: intel-wired-lan@osuosl.org, Petr Oros , netdev@vger.kernel.org CC: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexander Lobakin , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Henry Tieman , Anirudh Venkataramanan , Michal Swiatkowski , Jesse Brandeburg , Preethi Banala , Kiran Patil , Dan Nowlin , Stephen Hemminger , intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_iwl-net_02/10=5D_ice=3A_fix_IRQ_fr?= =?US-ASCII?Q?eeing_in_ice=5Fvsi=5Freq=5Firq=5Fmsix=28=29_error_path?= User-Agent: Thunderbird for Android In-Reply-To: <20261002130752.2597259-3-poros@redhat.com> References: <20261002130752.2597259-1-poros@redhat.com> <20261002130752.2597259-3-poros@redhat.com> Message-ID: <5E5BE0F3-4AB6-4DCB-A730-511D626B9189@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On October 2, 2026 3:07:44 PM GMT+02:00, Petr Oros wro= te: >The vectors are requested with the q_vector as dev_id, but the error >path frees them with &vsi->q_vectors[vector], which is the address of >the array slot=2E devm_free_irq() finds no matching devres entry, warns >and leaves the IRQ requested=2E The unwind also tries to free vectors tha= t >the request loop skipped because they have no rings=2E > >Forcing request_irq to fail on the fourth vector during ndo_open gives: > > ice 0000:04:00=2E2 enp4s0f2np2: MSIX request_irq failed, error: -16 > WARNING: kernel/irq/devres=2Ec:191 at devm_free_irq+0x30/0x40 > WARNING: kernel/irq/devres=2Ec:191 at devm_free_irq+0x30/0x40 > WARNING: kernel/irq/devres=2Ec:191 at devm_free_irq+0x30/0x40 > >and the three IRQs stay registered in /proc/interrupts while the >interface is down=2E > >Pass the q_vector as dev_id and skip the vectors without rings, which >the request loop never requested=2E > >i40e fixed the same mistake in commit 915470e1b44e ("i40e: fix IRQ >freeing in i40e_vsi_request_irq_msix error path")=2E > >Fixes: cdedef59deb0 ("ice: Configure VSIs for Tx/Rx") >Assisted-by: LLM >Signed-off-by: Petr Oros >--- > drivers/net/ethernet/intel/ice/ice_main=2Ec | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > >diff --git a/drivers/net/ethernet/intel/ice/ice_main=2Ec b/drivers/net/et= hernet/intel/ice/ice_main=2Ec >index f2121e79fca993=2E=2Ed246cde36ae726 100644 >--- a/drivers/net/ethernet/intel/ice/ice_main=2Ec >+++ b/drivers/net/ethernet/intel/ice/ice_main=2Ec >@@ -2582,8 +2582,12 @@ static int ice_vsi_req_irq_msix(struct ice_vsi *vs= i, char *basename) >=20 > free_q_irqs: > while (vector--) { >- irq_num =3D vsi->q_vectors[vector]->irq=2Evirq; >- devm_free_irq(dev, irq_num, &vsi->q_vectors[vector]); >+ struct ice_q_vector *q_vector =3D vsi->q_vectors[vector]; >+ >+ if (!q_vector->tx=2Etx_ring && !q_vector->rx=2Erx_ring) >+ continue; >+ >+ devm_free_irq(dev, q_vector->irq=2Evirq, q_vector); > } > return err; > } Reviewed-by: Ivan Vecera