From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B42972C15B3; Fri, 13 Jun 2025 10:08:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749809312; cv=none; b=kgf1pfX3WTxcR+2py/e3y/PLt+8GGY+pnYfKuCTuo1heDR29BO/27X5JL3Var1ViBIaEE/43AoD92redrnX6kEbRFj4M5YsHtqZUsZnSzS+eNN2oP/XFehU/eePg/4+y7ZW9fRnnrgoOKhaQ4q6YI+C6ppjW5ZluTG/xiARj96U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749809312; c=relaxed/simple; bh=s4XVAtXusftoKHAg337hEJV0678SCfgl4e9tbX5giyo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DIfBTm2XMdW8fIXiaW/jGzjHWP/Jw7GP6tT1Ty6KOKDab5R6P/9pCYYrbIAZJPJqwWXnWJYsE71XN0rNvL+iAsXlCe/6LeVVyFOOtoaRIX9eke/sy8cbms/P7R9iEa1iYTjInniNEb9psI/Wk78o+6KG3A7N1RlXp9l2nHz6Aes= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=kD6LEarE; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="kD6LEarE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1749809308; bh=s4XVAtXusftoKHAg337hEJV0678SCfgl4e9tbX5giyo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=kD6LEarEzpWs4xLCDq8R3pAuynqJ4ZeqL34E45wr5koEtk0OLXpj99IXiZOPcwdQb p5Iq05L9iBR7ggI0J3pXeWkLfxIzC3OBARgVEp3jK9TAr7ALCYeI+ySY9dPlZghRWd Ds1PASLejz3jlgX4r4PjG++FYlwy8Rc8gu87Mn+GzZ600aDAYXtVO74+/IlhFnWIk9 Hv+q+thA08ckoQ1i+NLj6LtKv1PkVv0h2O7VdtYvDkBvbwpwpjDynfZcaz8HA01UMZ HDx/hbVFOzgW4uB7GNYiYaXRC4ZeSjf1z4oyAriMshNGBeBv5R1piYPogkUgCzKZ70 JMEyPwRHQDWzQ== Received: from [192.168.1.90] (unknown [212.93.144.165]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 914CA17E0C18; Fri, 13 Jun 2025 12:08:26 +0200 (CEST) Message-ID: <5a1b4a52-2d6e-4270-82ac-494afe5c6556@collabora.com> Date: Fri, 13 Jun 2025 13:08:22 +0300 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/20] drm/rockchip: dw_hdmi_qp: switch to HWORD_UPDATE macro To: Nicolas Frattaroli , Yury Norov , Rasmus Villemoes , Jaehoon Chung , Ulf Hansson , Heiko Stuebner , Shreeya Patel , Mauro Carvalho Chehab , Sandy Huang , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Vinod Koul , Kishon Vijay Abraham I , Nicolas Frattaroli , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Shawn Lin , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Chanwoo Choi , MyungJoo Ham , Kyungmin Park , Qin Jian , Michael Turquette , Stephen Boyd , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: kernel@collabora.com, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, llvm@lists.linux.dev References: <20250612-byeword-update-v1-0-f4afb8f6313f@collabora.com> <20250612-byeword-update-v1-10-f4afb8f6313f@collabora.com> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: <20250612-byeword-update-v1-10-f4afb8f6313f@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/12/25 9:56 PM, Nicolas Frattaroli wrote: > The era of hand-rolled HIWORD_UPDATE macros is over, at least for those > drivers that use constant masks. > > Replace this driver's HIWORD_UPDATE with the HWORD_UPDATE from > bitfield.h. While at it, disambiguate the write GRF write to SOC_CON7 by > splitting the definition into the individual bitflags. This is done > because HWORD_UPDATE shifts the value for us according to the mask, so > writing the mask to itself to enable two bits is no longer something > that can be done. It should also not be done, because it hides the true > meaning of those two individual bit flags. > > HDMI output with this patch has been tested on both RK3588 and RK3576. > On the former, with both present HDMI connectors. > > Signed-off-by: Nicolas Frattaroli This looks good and works fine on Radxa ROCK 5B (RK3588). Will also verify on RK3576 as soon as I get a board (expected next week). Reviewed-by: Cristian Ciocaltea Tested-by: Cristian Ciocaltea