From: Ken Lewis <kennylewis@gmail.com>
To: Alexander Beregalov <a.beregalov@gmail.com>,
Sachin Sant <sachinp@in.ibm.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
linux-wireless@vger.kernel.org
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: April 22 Next : net/rfkill randconfig failure
Date: Thu, 23 Apr 2009 11:33:13 +0100 [thread overview]
Message-ID: <5a44caba0904230333v88a2a81j3f86cfb46b3ec33c@mail.gmail.com> (raw)
In-Reply-To: <a4423d670904230254v672798ddtda443e549ef45490@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 605 bytes --]
2009/4/23 Alexander Beregalov <a.beregalov@gmail.com>:
> 2009/4/22 Sachin Sant <sachinp@in.ibm.com>:
>> Today's next tree build (x86 randconfig) failed with
>>
>> net/rfkill/rfkill.c: In function 'update_rfkill_state':
>> net/rfkill/rfkill.c:99: error: implicit declaration of function
>> 'rfkill_led_trigger'
>> make[2]: *** [net/rfkill/rfkill.o] Error 1
>>
>> .config attached
>>
>
> Add CCs
I'm getting the same issue, but my .config does not include
CONFIG_RFKILL_LEDS. I use the attached patch to ensure the functions
were defined. Apols for the formatting: first patch atttempt.
Take care.
Ken.
[-- Attachment #2: next-20090423-rfkill-diff.txt --]
[-- Type: text/plain, Size: 532 bytes --]
diff --git a/net/rfkill/rfkill.c b/net/rfkill/rfkill.c
index 53430a7..fcdd5e0 100644
--- a/net/rfkill/rfkill.c
+++ b/net/rfkill/rfkill.c
@@ -75,6 +75,12 @@ static void rfkill_led_trigger_activate(struct led_classdev *led)
rfkill_led_trigger(rfkill, rfkill->state);
}
+#else
+static void rfkill_led_trigger(struct rfkill *rfkill,
+ enum rfkill_state state)
+{ }
+static void rfkill_led_trigger_activate(struct led_classdev *led)
+{ }
#endif /* CONFIG_RFKILL_LEDS */
static void rfkill_uevent(struct rfkill *rfkill)
prev parent reply other threads:[~2009-04-23 10:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090422154247.dbffd285.sfr@canb.auug.org.au>
2009-04-22 10:38 ` April 22 Next : net/rfkill randconfig failure Sachin Sant
2009-04-23 9:54 ` Alexander Beregalov
2009-04-23 10:33 ` Ken Lewis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a44caba0904230333v88a2a81j3f86cfb46b3ec33c@mail.gmail.com \
--to=kennylewis@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=a.beregalov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sachinp@in.ibm.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).