From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B48B8C43381 for ; Fri, 15 Feb 2019 14:24:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A7FF2192D for ; Fri, 15 Feb 2019 14:24:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729863AbfBOOYI (ORCPT ); Fri, 15 Feb 2019 09:24:08 -0500 Received: from www62.your-server.de ([213.133.104.62]:53688 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727648AbfBOOYI (ORCPT ); Fri, 15 Feb 2019 09:24:08 -0500 Received: from [88.198.220.130] (helo=sslproxy01.your-server.de) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1guePN-0006QK-GV; Fri, 15 Feb 2019 15:24:05 +0100 Received: from [2a02:1205:34ea:9e0:5681:e3d2:fbd:7e53] (helo=linux.home) by sslproxy01.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1guePM-0004EA-Jw; Fri, 15 Feb 2019 15:24:05 +0100 Subject: Re: [PATCH bpf-next] net: bpf: remove XDP_QUERY_XSK_UMEM enumerator To: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , ast@kernel.org, netdev@vger.kernel.org Cc: Jan Sokolowski , magnus.karlsson@intel.com, magnus.karlsson@gmail.com, intel-wired-lan@lists.osuosl.org References: <20190213170729.13845-1-bjorn.topel@gmail.com> From: Daniel Borkmann Message-ID: <5a6168bd-1848-60e8-b0ff-bb65ce7db460@iogearbox.net> Date: Fri, 15 Feb 2019 15:23:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20190213170729.13845-1-bjorn.topel@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.100.2/25361/Fri Feb 15 12:07:11 2019) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 02/13/2019 06:07 PM, Björn Töpel wrote: > From: Jan Sokolowski > > Commit c9b47cc1fabc ("xsk: fix bug when trying to use both copy and > zero-copy on one queue id") moved the umem query code to the AF_XDP > core, and therefore removed the need to query the netdevice for a > umem. > > This patch removes XDP_QUERY_XSK_UMEM and all code that implement that > behavior, which is just dead code. > > Signed-off-by: Jan Sokolowski Applied, thanks!