From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH v2 bpf-next 1/1] libbpf: make bpf_object__open default to UNSPEC Date: Fri, 23 Nov 2018 22:49:48 +0100 Message-ID: <5a8c19bb-1e4a-e546-e75f-0f7a592b3d5b@iogearbox.net> References: <20181123205812.2562-1-tehnerd@tehnerd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: "Nikita V. Shirokov" , Alexei Starovoitov Return-path: Received: from www62.your-server.de ([213.133.104.62]:40546 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726948AbeKXIfu (ORCPT ); Sat, 24 Nov 2018 03:35:50 -0500 In-Reply-To: <20181123205812.2562-1-tehnerd@tehnerd.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/23/2018 09:58 PM, Nikita V. Shirokov wrote: > currently by default libbpf's bpf_object__open requires > bpf's program to specify version in a code because of two things: > 1) default prog type is set to KPROBE > 2) KPROBE requires (in kernel/bpf/syscall.c) version to be specified > > in this patch i'm changing default prog type to UNSPEC and also changing > requirments for version's section to be present in object file. > now it would reflect what we have today in kernel > (only KPROBE prog type requires for version to be explicitly set). > > v1 -> v2: > - RFC tag has been dropped > > Signed-off-by: Nikita V. Shirokov Applied, thanks!