From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01F7DC61CE8 for ; Sat, 19 Jan 2019 21:07:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C202C2084C for ; Sat, 19 Jan 2019 21:07:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D6G0/4sj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729324AbfASVHt (ORCPT ); Sat, 19 Jan 2019 16:07:49 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:33878 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729288AbfASVHs (ORCPT ); Sat, 19 Jan 2019 16:07:48 -0500 Received: by mail-wr1-f66.google.com with SMTP id j2so19133055wrw.1 for ; Sat, 19 Jan 2019 13:07:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JIeOU+A2BzTtlI2vNUHtNc8twfd9MtN7YomHipsno4g=; b=D6G0/4sjscvwpntBHzaie/I34mLx0CDqbL055n4wa6nmiMxxMxGPiiQqbq1u0M3gtv AoCYKhvU6zAvyK0Py2dzWzUPgPkeQyW1UR10rJPHl68tp+Gkq2oNtlrefQQzvayEUlMS xioH4Zt1HXBJgIfqDAJ8awc15a9hOD32TqJbHnIUmDW4OiEyNSAKCOJ9c2rqbvXWO8FX RkEc7wpj7w7XIYA3cZOqKFaDJ9+Q0DecOaaunyt0XNw5PkOUpPtTMWPDvA5VusTdJW8w 0W9wnSEirNTwNYX3HmdTZZ2MvAgIH27lMvb08mUXeKUPbSktMPCYiYyY6ah7gKIu6E59 OaaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JIeOU+A2BzTtlI2vNUHtNc8twfd9MtN7YomHipsno4g=; b=aT1osqv/d0V+5vTfJM0XSM+azmA3AbEiy5LVmOkraNFuQTI2bStf5fLfHnH1axD2xc yLrcZg2Ds3YHWgg+SiQGKZ3PWEazX0o85KieVldHupcPa/JZxnnpRkDpkJg23VeForPj oGIBqsx6QV6YLEOLTNY8JA/GCGVha8Dm+Gy+lUZ0ZLMIv0b95Aa2D0UJQKFXhV8p02+s nsA/Ueki3PwIioYEbRxW++fnY0600gSdIfUrDpeG4e1nH2+s8J1ZAClfdDDn15IIxTsH pmKUuCizEIbvJQKT9zDA//0noX1RuUDTBJo/zMc9Yhe4RxngZMXgIHjTmbFw1qQY5wv9 dyMA== X-Gm-Message-State: AJcUukdy+rRdCjfKrWxgblw8pEx+uqGL+UFpuDIAMHXSHHiwJH2XMTso 6MNQkouQSVnaa3nISdpAbpFriute X-Google-Smtp-Source: ALg8bN68FOvDTxF+aZWNo1lr+ewCCvH3ba8zq7b7kEE+k1HKuYIEeRzD4jPGJdpj+Bh8/m+kdOtVFw== X-Received: by 2002:adf:f149:: with SMTP id y9mr23404231wro.284.1547932066216; Sat, 19 Jan 2019 13:07:46 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:e877:8d0c:cdf0:81fd? (p200300EA8BF1E200E8778D0CCDF081FD.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:e877:8d0c:cdf0:81fd]) by smtp.googlemail.com with ESMTPSA id d16sm70799880wru.52.2019.01.19.13.07.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 Jan 2019 13:07:45 -0800 (PST) Subject: [PATCH net-next v2 2/8] r8169: remove unneeded call in pcierr From: Heiner Kallweit To: David Miller , Realtek linux nic maintainers Cc: "netdev@vger.kernel.org" References: Message-ID: <5aaf7e6f-a2b5-944f-fd49-06b06484e4f7@gmail.com> Date: Sat, 19 Jan 2019 22:03:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org rtl8169_hw_reset() is called as part of the reset routine which is scheduled in the line after. So we can remove the call to rtl8169_hw_reset() here. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index b2e30e302..fd3c6a548 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -6196,8 +6196,6 @@ static void rtl8169_pcierr_interrupt(struct net_device *dev) dev->features &= ~NETIF_F_HIGHDMA; } - rtl8169_hw_reset(tp); - rtl_schedule_task(tp, RTL_FLAG_TASK_RESET_PENDING); } -- 2.20.1