From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Fernando Fernandez Mancera <fmancera@suse.de>, netdev@vger.kernel.org
Cc: stephen@networkplumber.org, brian.haley@hp.com, horms@kernel.org,
pabeni@redhat.com, kuba@kernel.org, edumazet@google.com,
davem@davemloft.net, idosch@nvidia.com, dsahern@kernel.org
Subject: Re: [PATCH net v2 5/7] ipv6: reset value and position for proxy_ndp sysctl restart
Date: Mon, 22 Jun 2026 13:48:12 +0200 [thread overview]
Message-ID: <5adce61f-baa3-4687-8db9-b75e718c42e8@6wind.com> (raw)
In-Reply-To: <20260620161850.7114-6-fmancera@suse.de>
Le 20/06/2026 à 18:18, Fernando Fernandez Mancera a écrit :
> When handling proxy_ndp, if rtnl_net_trylock() fails, the operation is
> retried but as the value was already modified by the initial
> proc_dointvec() call, the restarted syscall will read the newly modified
> value as the 'old' state.
>
> Fix this by taking the RTNL lock before parsing the input value if the
> operation is a write.
>
> Fixes: c92d5491a6d9 ("netconf: add support for IPv6 proxy_ndp")
> Signed-off-by: Fernando Fernandez Mancera <fmancera@suse.de>
Reviewed-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
next prev parent reply other threads:[~2026-06-22 11:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-20 16:18 [PATCH net v2 0/7] ipv6: fix sysctl error handling and missing notifications Fernando Fernandez Mancera
2026-06-20 16:18 ` [PATCH net v2 1/7] ipv6: fix error handling in disable_ipv6 sysctl Fernando Fernandez Mancera
2026-06-20 16:18 ` [PATCH net v2 2/7] ipv6: fix error handling in ignore_routes_with_linkdown sysctl Fernando Fernandez Mancera
2026-06-20 16:18 ` [PATCH net v2 3/7] ipv6: fix error handling in forwarding sysctl Fernando Fernandez Mancera
2026-06-20 16:18 ` [PATCH net v2 4/7] ipv6: fix error handling in disable_policy sysctl Fernando Fernandez Mancera
2026-06-20 16:18 ` [PATCH net v2 5/7] ipv6: reset value and position for proxy_ndp sysctl restart Fernando Fernandez Mancera
2026-06-22 11:48 ` Nicolas Dichtel [this message]
2026-06-20 16:18 ` [PATCH net v2 6/7] ipv6: fix missing notification for ignore_routes_with_linkdown Fernando Fernandez Mancera
2026-06-20 16:18 ` [PATCH net v2 7/7] ipv6: reset position for force_forwarding sysctl restart Fernando Fernandez Mancera
2026-06-22 11:42 ` Ido Schimmel
2026-06-22 12:19 ` Fernando Fernandez Mancera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5adce61f-baa3-4687-8db9-b75e718c42e8@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=brian.haley@hp.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fmancera@suse.de \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox