From: Paolo Abeni <pabeni@redhat.com>
To: Ruoyu Wang <ruoyuw560@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: dsa: mv88e6xxx: Avoid uninitialized value on MDIO read error
Date: Thu, 20 Aug 2026 13:49:35 +0200 [thread overview]
Message-ID: <5ae54784-8076-4b3a-a2fe-14fe64485571@redhat.com> (raw)
In-Reply-To: <20260815151713.3757248-1-ruoyuw560@gmail.com>
On 8/15/26 5:17 PM, Ruoyu Wang wrote:
> mv88e6xxx_mdio_read() applies the internal PHY model-number workaround
> before returning a Clause 22 read error. Since the PHY read may leave
> val untouched on failure, the workaround can consume an uninitialized
> value.
>
> Return the PHY read error immediately after dropping the register lock.
> Successful reads continue through the workaround and return val as
> before.
>
> This issue was found by a static analysis checker and confirmed by
> manual source review.
>
> Assisted-by: unnamed:deepseek-v4-pro typestate
> Signed-off-by: Ruoyu Wang <ruoyuw560@gmail.com>
## Form letter - net-next-closed
We have already submitted our pull request with net-next material for v7.3,
and therefore net-next is closed for new drivers, features, code refactoring
and optimizations. We are currently accepting bug fixes only.
Please repost when net-next reopens after Aug 31st.
RFC patches sent for review only are obviously welcome at any time.
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
prev parent reply other threads:[~2026-08-20 11:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-15 15:17 [PATCH net-next v2] net: dsa: mv88e6xxx: Avoid uninitialized value on MDIO read error Ruoyu Wang
2026-08-20 11:49 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ae54784-8076-4b3a-a2fe-14fe64485571@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=ruoyuw560@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox