From: Daniel Borkmann <daniel@iogearbox.net>
To: "Alexis Lothoré" <alexis.lothore@bootlin.com>,
"Bochao Cao" <bochaolucky@gmail.com>,
bpf@vger.kernel.org
Cc: Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Ihor Solodrai <ihor.solodrai@linux.dev>,
Jiayuan Chen <jiayuan.chen@linux.dev>,
Alexei Starovoitov <ast@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Song Liu <song@kernel.org>,
Emil Tsalapatis <emil@etsalapatis.com>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Lorenzo Bianconi <lorenzo@kernel.org>
Subject: Re: [PATCH bpf-next v2] selftests/bpf: Track test_xdp_features DUT processes
Date: Mon, 31 Aug 2026 10:56:00 +0200 [thread overview]
Message-ID: <5af98c98-0633-4efd-89ca-43eb9ef0cd75@iogearbox.net> (raw)
In-Reply-To: <DL2YUKA3J3CG.1GUS47SLVPRNX@bootlin.com>
On 8/31/26 9:55 AM, Alexis Lothoré wrote:
> On Fri Aug 28, 2026 at 8:10 AM CEST, Bochao Cao wrote:
>> Thanks Daniel and Alexis.
>>
>> Dropping the procps dependency is not the primary motivation for
>> this change. I agree that Debian can remove the dependency independently.
>> The issue addressed by this patch is process isolation in the standalone
>> test. The current readiness check may observe an unrelated
>> concurrent xdp_features process, while cleanup may terminate every
>> xdp_features
>> process on the host. In addition, a DUT which exits before listening can
>> leave the test waiting indefinitely.
>>
>> Although this script is not currently run by the BPF CI, it remains
>> useful for testing real hardware,
>> so these process lifecycle issues can still affect users running the
>> test manually.
>>
>> Would it be acceptable to fix these issues in the script's current
>> location?
>> If the preferred direction is to move it under
>> tools/testing/selftests/drivers/net/hw/,
>> should the move be submitted first, with this fix rebased on top?
>
> I have no strong feeling about whether it should be moved or kept here,
> I'll let BPF/netdev maintainers express their opinions here (Jakub
> already suggested in [1] that there are helpers in net testing helpers
> that could help making it move to the net tests). I've added Lorenzo in
> CC, who is the original author of the script.
Given it is explicitly for testing real HW/driver capabilities wrt XDP,
it would make sense to me to migrate it over into
tools/testing/selftests/drivers/net/hw/ ; then vendors can run it also as
part of their netdev CI.
Thanks,
Daniel
> Alexis
>
> [1] https://lore.kernel.org/bpf/20240914063828.7bd73c5e@kernel.org/
>
prev parent reply other threads:[~2026-08-31 8:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 8:28 [PATCH bpf-next v2] selftests/bpf: Track test_xdp_features DUT processes Bochao Cao via B4 Relay
2026-08-12 9:23 ` bot+bpf-ci
2026-08-24 11:31 ` Daniel Borkmann
2026-08-24 14:49 ` Alexis Lothoré
[not found] ` <CAHKNYVXN0DAUzv2Lwm=oQ_K=zhi2iNyTO2e99s5F4M+Kr7u5tQ@mail.gmail.com>
[not found] ` <CAHKNYVV8gn-L_unjsxUZV=E+Rx4ouDBJX613_n4hevXP1rivyg@mail.gmail.com>
2026-08-28 9:32 ` Bochao Cao
2026-09-02 7:44 ` Emil Tsalapatis
2026-09-03 8:10 ` Bochao Cao
2026-09-03 13:44 ` Daniel Borkmann
2026-08-31 7:55 ` Alexis Lothoré
2026-08-31 8:56 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5af98c98-0633-4efd-89ca-43eb9ef0cd75@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexis.lothore@bootlin.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bochaolucky@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=ihor.solodrai@linux.dev \
--cc=jiayuan.chen@linux.dev \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).